From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 2AF77E07 for ; Wed, 23 Mar 2016 12:45:05 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP; 23 Mar 2016 04:45:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,382,1455004800"; d="scan'208";a="71757901" Received: from dkoncewi-mobl3.ger.corp.intel.com ([10.252.21.244]) by fmsmga004.fm.intel.com with SMTP; 23 Mar 2016 04:45:03 -0700 Received: by (sSMTP sendmail emulation); Wed, 23 Mar 2016 11:45:01 +0025 Date: Wed, 23 Mar 2016 11:45:01 +0000 From: Bruce Richardson To: "Ananyev, Konstantin" Cc: Harish Patil , "dev@dpdk.org" Message-ID: <20160323114501.GA3628@bricha3-MOBL3> References: <20160322213814.GA3920@bricha3-MOBL3> <2601191342CEEE43887BDE71AB97725836B20265@irsmsx105.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2601191342CEEE43887BDE71AB97725836B20265@irsmsx105.ger.corp.intel.com> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] Question on examples/multi_process app X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Mar 2016 11:45:05 -0000 On Wed, Mar 23, 2016 at 11:09:17AM +0000, Ananyev, Konstantin wrote: > Hi everyone, > > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson > > Sent: Tuesday, March 22, 2016 9:38 PM > > To: Harish Patil > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] Question on examples/multi_process app > > > > On Tue, Mar 22, 2016 at 08:03:42PM +0000, Harish Patil wrote: > > > Hi, > > > I have a question regarding symmetric_mp and mp_server applications under > > > examples/multi_process. In those apps, rte_eth_promiscuous_enable() is > > > called before rte_eth_dev_start(). Is this the correct way to initialize > > > the port/device? As per the description in > > > http://dpdk.org/doc/api/rte__ethdev_8h.html: > > > > > > "The functions exported by the application Ethernet API to setup a device > > > designated by its port identifier must be invoked in the following order: > > > > > > * rte_eth_dev_configure() > > > * rte_eth_tx_queue_setup() > > > * rte_eth_rx_queue_setup() > > > * rte_eth_dev_start() > > > > > > Then, the network application can invoke, in any order, the functions > > > exported by the Ethernet API to get the MAC address of a given device, to > > > get the speed and the status of a device physical link, to > > > receive/transmit [burst of] packets, and so on.” > > > > > > So should I consider this as an application issue or whether the PMD is > > > expected to handle it? If PMD is to handle it, then should the PMD be: > > > > > > 1) Rejecting the Promisc config? OR > > > 2) Cache the config and apply when dev_start() is called at later point? > > Yes as I remember 2) is done. > dev_start() invokes rte_eth_dev_config_restore(), which restores > promisc mode, mac addresses, etc. > > > > > > > Thanks, > > > Harish > > > > > Good question. I think most/all of the Intel adapters, - for which the app was > > originally written, way back in the day when there were only 2 PMDs in DPDK :) > > - will handle the promiscuous mode call either before or after the dev start. > > Assuming that's the case, and if it makes life easier for other driver writers, > > we should indeed standardize on one supported way of doing things - the way > > specified in the documentation being that one way, I would guess. > > > > So, e1000, ixgbe maintainers - do you see any issues with forcing the promiscuous > > mode set API to be called after the call to dev_start()? > > Not sure, why do we need to enforce that restriction? > Is there any problem with current way? It complicates things for driver writers is all, and conflicts slightly with what is stated in the docs. /Bruce