From: Bruce Richardson <bruce.richardson@intel.com>
To: "Loftus, Ciara" <ciara.loftus@intel.com>
Cc: Tetsuya Mukawa <mukawa@igel.co.jp>, "dev@dpdk.org" <dev@dpdk.org>,
"ann.zhuangyanying@huawei.com" <ann.zhuangyanying@huawei.com>,
"yuanhan.liu@linux.intel.com" <yuanhan.liu@linux.intel.com>
Subject: Re: [dpdk-dev] [PATCH] vhost PMD: Fix wrong handling of maximum value of rx/tx queues
Date: Wed, 23 Mar 2016 17:45:22 +0000 [thread overview]
Message-ID: <20160323174522.GB11680@bricha3-MOBL3> (raw)
In-Reply-To: <74F120C019F4A64C9B78E802F6AD4CC24F847A6D@IRSMSX106.ger.corp.intel.com>
On Tue, Mar 22, 2016 at 05:17:42PM +0000, Loftus, Ciara wrote:
> >
> > Currently, the maximum value of rx/tx queueus are kept by EAL. But,
> > the value are used like below different meanings in vhost PMD.
> > - The maximum value of current enabled queues.
> > - The maximum value of current supported queues.
> >
> > This wrong double meaning will cause an issue like below steps.
> >
> > * Invoke application with below option.
> > --vdev 'eth_vhost0,iface=<socket path>,queues=4'
> > * Configure queues like below.
> > rte_eth_dev_configure(portid, 2, 2, ...);
> > * Configure queues again like below.
> > rte_eth_dev_configure(portid, 4, 4, ...);
> >
> > The second rte_eth_dev_configure() will be failed because both
> > the maximum value of current enabled queues and supported queues
> > will be '2' after calling first rte_eth_dev_configure().
> >
> > To fix the issue, the patch prepare one more variable to keep the
> > number of maximum supported queues in vhost PMD.
> >
> > Signed-off-by: Tetsuya Mukawa <mukawa@igel.co.jp>
> > ---
<snip>
> Acked-by: Ciara Loftus <ciara.loftus@intel.com>
>
Applied to dpdk-next-net/rel_16_04
/Bruce
prev parent reply other threads:[~2016-03-23 17:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-22 8:09 Tetsuya Mukawa
2016-03-22 17:17 ` Loftus, Ciara
2016-03-23 1:07 ` Tetsuya Mukawa
2016-03-23 17:45 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160323174522.GB11680@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=ann.zhuangyanying@huawei.com \
--cc=ciara.loftus@intel.com \
--cc=dev@dpdk.org \
--cc=mukawa@igel.co.jp \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).