From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 6D8532931 for ; Thu, 24 Mar 2016 18:46:39 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP; 24 Mar 2016 10:46:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,386,1455004800"; d="scan'208";a="675103147" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.85]) by FMSMGA003.fm.intel.com with SMTP; 24 Mar 2016 10:46:34 -0700 Received: by (sSMTP sendmail emulation); Thu, 24 Mar 2016 17:46:33 +0025 Date: Thu, 24 Mar 2016 17:46:33 +0000 From: Bruce Richardson To: Pablo de Lara Cc: dev@dpdk.org, wenzhuo.lu@intel.com Message-ID: <20160324174632.GI13728@bricha3-MOBL3> References: <1458832675-666-1-git-send-email-pablo.de.lara.guarch@intel.com> <1458832924-1489-1-git-send-email-pablo.de.lara.guarch@intel.com> <20160324174458.GH13728@bricha3-MOBL3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160324174458.GH13728@bricha3-MOBL3> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v4 0/3] Fix incorrect max TX queue numbers for ixgbe X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Mar 2016 17:46:39 -0000 On Thu, Mar 24, 2016 at 05:44:58PM +0000, Bruce Richardson wrote: > On Thu, Mar 24, 2016 at 03:22:01PM +0000, Pablo de Lara wrote: > > IXGBE supports 128 TX queues. However, the full 128 queues > > are only available in VT and DCB mode. > > In normal default "none" mode (VT/DCB off) the maximum number > > of available queues is only 64. > > IXGBE doesn't check the mode when reporting the available > > number of queues. If a queue larger than 64 is used in default mode, > > the TX packets will be dropped silently. > > > > This patchset: > > > > - Modifies the device info to show the correct maximum number of available TX queues, > > depending on the mode. > > > > - Adds a check to forbid using a queue number larger than 64 > > during device configuration (in default mode), so that the problem is > > reported as early as possible. > > > > - It also changes the order of where the dev_conf parameters are copied > > into the dev structure so that the correct maximum number of queues > > is reported for the correct mode. > > > > Changes in v4: > > - Split the patch in three smaller patches > > - Updated release notes document > > > > Changes in v3: > > - Fixed wrong set of TX queues for 82596EB > > > > Changes in v2: > > > > - Reorder memcpy of device configuration in rte_eth_dev_configure(), > > so function gets the correct maximum number of queues > > (depending on the operation mode), before checking the > > requested number of queues. > > - Renamed new macro > > - Reworded/wrapped commit message > > > > Pablo de Lara (1): > > ethdev: copy device configuration earlier > > > > Wenzhuo Lu (2): > > ixgbe: fix incorrect tx queue number assignment > > ixgbe: fix incorrect max tx queue number > > > All three patches are fixes, so all three should have "Fixes" lines in them. > Please remember for next time! > > Thanks, > /Bruce Applied to dpdk-next-net/rel_16_04, with added fixes lines in each case. /Bruce