From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <yuanhan.liu@linux.intel.com> Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 5C25F2C05 for <dev@dpdk.org>; Wed, 30 Mar 2016 16:43:47 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP; 30 Mar 2016 07:43:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,416,1455004800"; d="scan'208";a="75935882" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.191]) by fmsmga004.fm.intel.com with ESMTP; 30 Mar 2016 07:43:45 -0700 Date: Wed, 30 Mar 2016 22:44:14 +0800 From: Yuanhan Liu <yuanhan.liu@linux.intel.com> To: Bruce Richardson <bruce.richardson@intel.com> Cc: Thomas Monjalon <thomas.monjalon@6wind.com>, dev@dpdk.org Message-ID: <20160330144414.GD3080@yliu-dev.sh.intel.com> References: <1459286986-31148-1-git-send-email-thomas.monjalon@6wind.com> <20160330014634.GC3080@yliu-dev.sh.intel.com> <20160330142740.GB21156@bricha3-MOBL3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160330142740.GB21156@bricha3-MOBL3> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH] scripts: check commit formatting X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 30 Mar 2016 14:43:47 -0000 On Wed, Mar 30, 2016 at 03:27:40PM +0100, Bruce Richardson wrote: > On Wed, Mar 30, 2016 at 09:46:34AM +0800, Yuanhan Liu wrote: > > On Tue, Mar 29, 2016 at 11:29:46PM +0200, Thomas Monjalon wrote: > > > The git messages have three parts: > > > 1/ the headline > > > 2/ the explanations > > > 3/ the footer tags > > > > > > The headline helps to quickly browse an history or catch instantly the > > > purpose of a commit. Making it short with some consistent wording > > > allows to easily parse it or match some patterns. > > > > > > The explanations must give some keys like the reason of the change. > > > Nothing can be automatically checked for this part. > > > > Actually, I think we might be able to do 2 tests here: > > > > - space line between paragraphs. > > > > - lines over 80 chars. > > 75 chars for commit messages, and 50 for commit titles :-) I'd agree that 75 char is better. My personal preference is actually 68 :) --yliu