From: Zhe Tao <zhe.tao@intel.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, jingjing.wu@intel.com
Subject: Re: [dpdk-dev] [PATCH v2] i40e: fix ipv6 TSO issue for tx function
Date: Thu, 31 Mar 2016 11:58:40 +0800 [thread overview]
Message-ID: <20160331035840.GA67384@intel.com> (raw)
In-Reply-To: <20160324150013.GG13728@bricha3-MOBL3>
On Thu, Mar 24, 2016 at 03:00:14PM +0000, Bruce Richardson wrote:
> On Wed, Mar 23, 2016 at 11:27:50AM +0800, Zhe Tao wrote:
> > Issue:
> > when using the following CLI in testpmd to enable ipv6 TSO feature
> > =============
> > set verbose 1
> > csum set ip hw 0
> > csum set udp hw 0
> > csum set tcp hw 0
> > csum set sctp hw 0
> > csum set outer-ip hw 0
> > csum parse_tunnel on 0
> > tso set 800 0
> > set fwd csum
> >
> > start
> > =============
>
> The "===" lines in the message are confusing patchwork. For a new version of
> this patch can you indent the commands rather than putting the "===" above and
> below. E.g.
>
> Issue:
> when using the following CLI in testpmd to enable ipv6 TSO feature
>
> set verbose 1
> csum set ip hw 0
> csum set udp hw 0
> ....
>
> Thanks,
> /Bruce
very good advise, will send the new patch, thanks!
Zhe Tao
next prev parent reply other threads:[~2016-03-31 12:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-22 13:13 [dpdk-dev] [PATCH] " Zhe Tao
2016-03-22 13:38 ` Ananyev, Konstantin
2016-03-22 18:41 ` Zhe Tao
2016-03-23 3:27 ` [dpdk-dev] [PATCH v2] " Zhe Tao
2016-03-23 12:46 ` Ananyev, Konstantin
2016-03-24 14:58 ` Bruce Richardson
2016-03-24 15:00 ` Bruce Richardson
2016-03-31 3:58 ` Zhe Tao [this message]
2016-03-31 12:15 ` [dpdk-dev] [PATCH v3] i40e: fix " Zhe Tao
2016-03-31 12:18 ` Bruce Richardson
2016-04-06 8:16 ` [dpdk-dev] [PATCH v4] " Zhe Tao
2016-04-06 11:23 ` Ananyev, Konstantin
2016-04-06 13:43 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160331035840.GA67384@intel.com \
--to=zhe.tao@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).