* [dpdk-dev] [PATCH] mlx5: fix RETA table size
@ 2016-03-30 15:27 Yaacov Hazan
2016-03-31 8:58 ` Adrien Mazarguil
2016-03-31 9:21 ` [dpdk-dev] [PATCH v2] " Yaacov Hazan
0 siblings, 2 replies; 5+ messages in thread
From: Yaacov Hazan @ 2016-03-30 15:27 UTC (permalink / raw)
To: dev; +Cc: Yaacov Hazan
Change RETA table size to use 256 entries for better performance.
Fixes: ebb30ec64a68 ("mlx5: increase RETA table size")
Signed-off-by: Yaacov Hazan <yaacovh@mellanox.com>
---
drivers/net/mlx5/mlx5_defs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5_defs.h b/drivers/net/mlx5/mlx5_defs.h
index 195440c..09207d9 100644
--- a/drivers/net/mlx5/mlx5_defs.h
+++ b/drivers/net/mlx5/mlx5_defs.h
@@ -52,7 +52,7 @@
#define MLX5_PMD_TX_PER_COMP_REQ 64
/* RSS Indirection table size. */
-#define RSS_INDIRECTION_TABLE_SIZE 512
+#define RSS_INDIRECTION_TABLE_SIZE 256
/* Maximum number of Scatter/Gather Elements per Work Request. */
#ifndef MLX5_PMD_SGE_WR_N
--
1.9.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] mlx5: fix RETA table size
2016-03-30 15:27 [dpdk-dev] [PATCH] mlx5: fix RETA table size Yaacov Hazan
@ 2016-03-31 8:58 ` Adrien Mazarguil
2016-03-31 9:21 ` [dpdk-dev] [PATCH v2] " Yaacov Hazan
1 sibling, 0 replies; 5+ messages in thread
From: Adrien Mazarguil @ 2016-03-31 8:58 UTC (permalink / raw)
To: Yaacov Hazan; +Cc: dev
Yaacov,
On Wed, Mar 30, 2016 at 06:27:19PM +0300, Yaacov Hazan wrote:
> Change RETA table size to use 256 entries for better performance.
>
> Fixes: ebb30ec64a68 ("mlx5: increase RETA table size")
>
> Signed-off-by: Yaacov Hazan <yaacovh@mellanox.com>
> ---
> drivers/net/mlx5/mlx5_defs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/mlx5/mlx5_defs.h b/drivers/net/mlx5/mlx5_defs.h
> index 195440c..09207d9 100644
> --- a/drivers/net/mlx5/mlx5_defs.h
> +++ b/drivers/net/mlx5/mlx5_defs.h
> @@ -52,7 +52,7 @@
> #define MLX5_PMD_TX_PER_COMP_REQ 64
>
> /* RSS Indirection table size. */
> -#define RSS_INDIRECTION_TABLE_SIZE 512
> +#define RSS_INDIRECTION_TABLE_SIZE 256
Can you describe how using a smaller indirection table size improves
performance? Thanks.
--
Adrien Mazarguil
6WIND
^ permalink raw reply [flat|nested] 5+ messages in thread* [dpdk-dev] [PATCH v2] mlx5: fix RETA table size
2016-03-30 15:27 [dpdk-dev] [PATCH] mlx5: fix RETA table size Yaacov Hazan
2016-03-31 8:58 ` Adrien Mazarguil
@ 2016-03-31 9:21 ` Yaacov Hazan
2016-03-31 9:36 ` Adrien Mazarguil
1 sibling, 1 reply; 5+ messages in thread
From: Yaacov Hazan @ 2016-03-31 9:21 UTC (permalink / raw)
To: dev; +Cc: adrien.mazarguil, Yaacov Hazan
When the number of RX queues is not a power of two,
the RETA table is configured to its maximum size for
better balancing.
Testing showed that limiting its size to 256 improves performance
noticeably with little to no impact on balancing results.
Fixes: ebb30ec64a68 ("mlx5: increase RETA table size")
Signed-off-by: Yaacov Hazan <yaacovh@mellanox.com>
---
drivers/net/mlx5/mlx5_defs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5_defs.h b/drivers/net/mlx5/mlx5_defs.h
index 195440c..09207d9 100644
--- a/drivers/net/mlx5/mlx5_defs.h
+++ b/drivers/net/mlx5/mlx5_defs.h
@@ -52,7 +52,7 @@
#define MLX5_PMD_TX_PER_COMP_REQ 64
/* RSS Indirection table size. */
-#define RSS_INDIRECTION_TABLE_SIZE 512
+#define RSS_INDIRECTION_TABLE_SIZE 256
/* Maximum number of Scatter/Gather Elements per Work Request. */
#ifndef MLX5_PMD_SGE_WR_N
--
1.9.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH v2] mlx5: fix RETA table size
2016-03-31 9:21 ` [dpdk-dev] [PATCH v2] " Yaacov Hazan
@ 2016-03-31 9:36 ` Adrien Mazarguil
2016-03-31 13:00 ` Thomas Monjalon
0 siblings, 1 reply; 5+ messages in thread
From: Adrien Mazarguil @ 2016-03-31 9:36 UTC (permalink / raw)
To: Yaacov Hazan; +Cc: dev
On Thu, Mar 31, 2016 at 12:21:08PM +0300, Yaacov Hazan wrote:
> When the number of RX queues is not a power of two,
> the RETA table is configured to its maximum size for
> better balancing.
>
> Testing showed that limiting its size to 256 improves performance
> noticeably with little to no impact on balancing results.
>
> Fixes: ebb30ec64a68 ("mlx5: increase RETA table size")
>
> Signed-off-by: Yaacov Hazan <yaacovh@mellanox.com>
Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
--
Adrien Mazarguil
6WIND
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH v2] mlx5: fix RETA table size
2016-03-31 9:36 ` Adrien Mazarguil
@ 2016-03-31 13:00 ` Thomas Monjalon
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2016-03-31 13:00 UTC (permalink / raw)
To: Yaacov Hazan; +Cc: dev, Adrien Mazarguil
2016-03-31 11:36, Adrien Mazarguil:
> On Thu, Mar 31, 2016 at 12:21:08PM +0300, Yaacov Hazan wrote:
> > When the number of RX queues is not a power of two,
> > the RETA table is configured to its maximum size for
> > better balancing.
> >
> > Testing showed that limiting its size to 256 improves performance
> > noticeably with little to no impact on balancing results.
> >
> > Fixes: ebb30ec64a68 ("mlx5: increase RETA table size")
> >
> > Signed-off-by: Yaacov Hazan <yaacovh@mellanox.com>
>
> Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Applied, thanks
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-03-31 13:02 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-30 15:27 [dpdk-dev] [PATCH] mlx5: fix RETA table size Yaacov Hazan
2016-03-31 8:58 ` Adrien Mazarguil
2016-03-31 9:21 ` [dpdk-dev] [PATCH v2] " Yaacov Hazan
2016-03-31 9:36 ` Adrien Mazarguil
2016-03-31 13:00 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).