From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id B994A93FA for ; Thu, 31 Mar 2016 18:17:37 +0200 (CEST) Received: by mail-wm0-f51.google.com with SMTP id 127so139964200wmu.1 for ; Thu, 31 Mar 2016 09:17:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=wH0zF64KZ5cI2fKmDFXCVA/6Ulys4Zlk/ihGpfnC0ZM=; b=dFI6mLIBQyGE6HnIK0zPa+zV2238BdCzL2hSoOdF9w1k8n7EZXYoBenaG01O9rOJjx Zv38GDQE6wgaRiQTQWUgWo7i8/eI+B+F6/+em76/X0DO7+5oqb8NQe/ed85czUeh07/x xKXAJ6HhwSvm8d2rs14bs+ILI/4UB3ZBjiUX8+EN9t55yyWM9JVAasNjciXGGOKbPzCU q1BALo7FzbFLZfKp4m+R+cSMxBkjfjIoYQb3pv2OlhDZ27JfA20A7I6qJKJpCd52NA1R FGI2l9rZG82oRacg8m9BVu0FqXje49Ai2rt6LLE3y2g9M1d1HJgxE0kaRHKgAQiGbCVE sq+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=wH0zF64KZ5cI2fKmDFXCVA/6Ulys4Zlk/ihGpfnC0ZM=; b=K4sApfSU9zQwhNJSRFMzhEjGRLqxNQO6pa2/I8VDranvd0j7LtZFW2L6nWPdr7V+bd cH+3rmGAUjs/C88TH5RDskJhY/F4LRrIFefTUz/YrDnMPucpgJaH46nBMHHH0Vp49JRh OeJnCWpud/t9ITyNm2voYcSzNpyapnM4nFyzWJw0Ls7MU51bi0R5HEaX9/txA+V9UdPz EiROw4jBSmcVC85tYL36Yr+wHd478/94TJUCZgOWR5O6GeXTnKrRDQ7Cy7oufTTqIG9/ aTsTCVR1WEtyGve+auQAlY+Zvi4EUwxBzgVkuQ4iOVOL8f2AAYnT0qewvIlbb7rm6SU2 GMlw== X-Gm-Message-State: AD7BkJKjfOJhYoYWLveVBSzRf6xGkgaUeJ3DF+1w/PC60M1xjLaZRF9/yVhwA4KzDSk2SXaB X-Received: by 10.194.60.100 with SMTP id g4mr16133491wjr.30.1459441057535; Thu, 31 Mar 2016 09:17:37 -0700 (PDT) Received: from 6wind.com (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id h7sm25523277wmf.9.2016.03.31.09.17.33 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 31 Mar 2016 09:17:36 -0700 (PDT) Date: Thu, 31 Mar 2016 18:17:19 +0200 From: Adrien Mazarguil To: Thomas Monjalon Cc: Marc Sune , "Xu, Qian Q" , "Xing, Beilei" , dev@dpdk.org, "Ananyev, Konstantin" , "Lu, Wenzhuo" , "Richardson, Bruce" , "Glynn, Michael J" Message-ID: <20160331161719.GS27079@6wind.com> Mail-Followup-To: Thomas Monjalon , Marc Sune , "Xu, Qian Q" , "Xing, Beilei" , dev@dpdk.org, "Ananyev, Konstantin" , "Lu, Wenzhuo" , "Richardson, Bruce" , "Glynn, Michael J" References: <1458934950-23333-1-git-send-email-thomas.monjalon@6wind.com> <1458955640-22951-1-git-send-email-marcdevel@gmail.com> <2317112.HmzsiIB8a5@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2317112.HmzsiIB8a5@xps13> Subject: Re: [dpdk-dev] [PATCH v13 0/8] ethdev: 100G and link speed API refactoring X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Mar 2016 16:17:37 -0000 On Sat, Mar 26, 2016 at 09:11:38AM +0100, Thomas Monjalon wrote: > > v13: > > - Fix startup regression; revert flip of ETH_LINK_SPEED_FIXED and > > ETH_LINK_SPEED_AUTONEG values. ETH_LINK_SPEED_AUTONEG is now 0. > > As commented earlier, I would prefer avoiding this revert. > Comments are welcome. I've tested v13 using testpmd and ixgbe. Performed the following checks: - Port start/stop - OK, link speed is displayed correctly. - Forcing 1G / duplex auto - OK. - Forcing 10G / duplex auto - OK. - Forcing 10G / duplex half - half is not allowed (expected). - Forcing 40G / duplex auto - unsupported, causes port start to fail (expected). - Forcing 1G / duplex full - OK. - Forcing 100 / duplex half - unsupported, causes port start to fail (expected). - Forcing 100 / duplex full - OK. - Traffic flows whenever link speed is supported/negotiated. Tested-by: Adrien Mazarguil -- Adrien Mazarguil 6WIND