From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f42.google.com (mail-pa0-f42.google.com [209.85.220.42]) by dpdk.org (Postfix) with ESMTP id 7B43B2965 for ; Fri, 1 Apr 2016 17:44:25 +0200 (CEST) Received: by mail-pa0-f42.google.com with SMTP id td3so93307313pab.2 for ; Fri, 01 Apr 2016 08:44:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2mGrC8YyHPiQOLT6MEqJer49LsWVjLAHmn440b57Jag=; b=pTFp5LiIgmb/mNri9w2+myAuQqTGkM0kjiIedlIze61m0RhJ3BQwcoBTLDuIujHcC6 zpAenKs/yf40B9ToX2dy0IAzOgjV9ZjtCyCFT9+9wKxYrHf3hy/WmiX9B1NhJE/r7HT6 tlVLE+QSHiG1p8ReIdJCI19qdG3PWVxDA4MD6DITTz7IUJn3S+ORcbErvh4A7oJh3Mbo G2G+h+e2OJwBKV504BuIlzIS17U3IVqMf5Om0dIdtHST5Iu/SUu+iCsUgAsl4PNb9vFX BKeREV3j7kewAB2o39WVre/KfAtqRNpqHnOMSUJtkOvi2cmtQsdcXegYHK+9nPwMGBGV 3BbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2mGrC8YyHPiQOLT6MEqJer49LsWVjLAHmn440b57Jag=; b=jC0TSRyjEBNDI4J8s9Q4Tg1HExjDcBxtNtlNGELV8NoQFFG8MZFQe1o2zmj52v6upL XlHCEHdOIiHlH6A3xW7p0IxV/DOSPI/ssFZR3lXI+bzbLCjqHP/NmIO10BksPTwVhGj4 6vggiuKD17P9t3tyunBB5T/QNNJrMgXH6qETBf59cAVdPYiz9kmr2g6PB5N6zya8AtCN IhA5ywG8xvH11HyZkXSIDqfwSf6CLyubWrviSQ1pheyXtRBrc7Q7ERb6jU5UZqR/6f0J +GUODbrgkLWBN2CJ06+46h6NpRwtp/vRQUlA4DF+FgXk84xGToI7uaRYcIbpJNJIlzdt zw3A== X-Gm-Message-State: AD7BkJIVCyO/X95pT38UE4HXpCOa07/YyKWP82SfE1R7OXwxQntRH04tQAdcJEe7g/yDSg== X-Received: by 10.66.136.78 with SMTP id py14mr25295502pab.113.1459525464792; Fri, 01 Apr 2016 08:44:24 -0700 (PDT) Received: from xeon-e3 (static-50-53-73-178.bvtn.or.frontiernet.net. [50.53.73.178]) by smtp.gmail.com with ESMTPSA id tb10sm22457236pab.22.2016.04.01.08.44.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 01 Apr 2016 08:44:24 -0700 (PDT) Date: Fri, 1 Apr 2016 08:44:40 -0700 From: Stephen Hemminger To: Rasesh Mody Cc: , , , , , Message-ID: <20160401084440.05f3dcd3@xeon-e3> In-Reply-To: <1459476927-21387-1-git-send-email-rasesh.mody@qlogic.com> References: <1459476927-21387-1-git-send-email-rasesh.mody@qlogic.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 00/10] qede: Add qede PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Apr 2016 15:44:25 -0000 On Thu, 31 Mar 2016 19:15:17 -0700 Rasesh Mody wrote: > Hi Thomas, Bruce, > > The v5 series incorporates the following review comments: > - move adapter_info logs under debug > - implement qede_mac_addr_remove() > - remove unused rc variable in qede_dev_configure() > - fix indentation in qede_dev_info_get() > - use c99 style struct init in qede_config_accept_any_vlan() > - check error in qede_config_rx_mode() > - update overview.rst since patch didn't apply > > The patches are generated and tested against latest dpdk based off of > v16.04-rc2. > > These patches are checked using checkpatch.sh with following additional > ignore option: > options="$options --ignore=BIT_MACRO,CONCATENATED_STRING" > > Please apply! Looks good. One question, is there any restriction on number of Tx queues, relative to number of Rx queues. Is it possible to have 8 Tx queues but only 2 Rx queues? I know bnx2x and some other drivers have that kind of restriction. Acked-by: Stephen Hemminger