From: Stephen Hemminger <stephen@networkplumber.org>
To: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Cc: "Zhang, Helin" <helin.zhang@intel.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] ixgbe: cleanup whitespace and formatting issues
Date: Mon, 4 Apr 2016 18:56:26 -0700 [thread overview]
Message-ID: <20160404185626.26c4b1fe@xeon-e3> (raw)
In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09090344188F@shsmsx102.ccr.corp.intel.com>
On Tue, 5 Apr 2016 00:57:16 +0000
"Lu, Wenzhuo" <wenzhuo.lu@intel.com> wrote:
> Hi Stephen,
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen Hemminger
> > Sent: Tuesday, April 5, 2016 12:14 AM
> > To: Zhang, Helin; Ananyev, Konstantin
> > Cc: dev@dpdk.org; Stephen Hemminger
> > Subject: [dpdk-dev] [PATCH] ixgbe: cleanup whitespace and formatting issues
> >
> > This driver was one of the originals and has lots of little whitespace issues.
> >
> > PS: I know Intel doesn't like whitespace changes, there is never a good time
> > to do this, but no resuliting binary changes and it is unlikely that more
> > changes to this driver will occur this late in release cycle.
> >
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> Thanks for this patch. I think it's good to make the format better :)
> But there's some checkpatch error and warnings, like this,
> ERROR: "foo* bar" should be "foo *bar"
> #508: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:4256:
> +ixgbe_uc_hash_table_set(struct rte_eth_dev *dev, struct ether_addr* mac_addr,
>
I didn't fix all the checkpatch errors, just the easy ones.
next prev parent reply other threads:[~2016-04-05 1:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-04 16:14 Stephen Hemminger
2016-04-05 0:57 ` Lu, Wenzhuo
2016-04-05 1:56 ` Stephen Hemminger [this message]
2016-04-06 1:41 ` Lu, Wenzhuo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160404185626.26c4b1fe@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).