From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f180.google.com (mail-pf0-f180.google.com [209.85.192.180]) by dpdk.org (Postfix) with ESMTP id 934A5137C for ; Tue, 5 Apr 2016 03:56:15 +0200 (CEST) Received: by mail-pf0-f180.google.com with SMTP id c20so47729554pfc.1 for ; Mon, 04 Apr 2016 18:56:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=WKPbG2q9CE3uE0KGDIgZww56DK4qFgoHYjBOzNRdjBg=; b=sRJlTHlIzWIurDa4E/pALizCJOyyGtA29XY1icjAVSAqMiObgCP9JZvGop6jPjVW1l cZEeUQiGqhwAnsIFYQVwFD9SHjcTs5aEbAA5iTfE0ISU+kAnq0kan/wVkKS3KgB4yA8j F+etGzxN6SozXnXxAtrrqYWzVZTeobAC9iSna8/GI3kFKc1F6PkpYWkmgk7oYwwPE9tJ BY+yGsn+/H8h0rCkJH/pNghrb5Za7p9jUOq93m9EOJ7XLdkJdoD+d6fgulZIHAmcyuGC ulnQVZJ7sHk2pMSsVx8x5DHhcS/sDEmlFm8JAdx9N9Z31j0WlOFQLFmNBmvjRAUWAKRc 7TIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WKPbG2q9CE3uE0KGDIgZww56DK4qFgoHYjBOzNRdjBg=; b=GnbW28fqCWQGWZpt8lCcrxY2lCc8wOJy0iyzh5rpGOzRZN63JOqiHiZ14jjaU0Kipg T/m5c26S64uHCP0CSzYwJJKTFM1xjAN5/MS7N/z6iAbExN/UAc2iKP/puyUvQbMPNJ61 Rn9uFp7D8xdXpz+Yl0zMufmy5Tg5uRR7Iqd8DAlyYgI6XyKBh5rEfNJ0ccMNWNehvGan pdzjfZDfc8l6ypZhtc2dWxHtTEgvEHjctoMa4PPYzNIJmW0TdjsVeqGMSKsfg28Ixiup wrzyMVn0mFXiKTElDRxvqRMHSFk5q8QGkrEUJRvarTMXrFVvXPLyTfWkBcAuUxVqNqF5 cvdA== X-Gm-Message-State: AD7BkJKdjE6u+ICaGK7JUum+qdvRf7TU02elDRNzW5qkvA+/MSv7OUzWExF1dQ5Ie1QLdg== X-Received: by 10.98.87.5 with SMTP id l5mr25158731pfb.7.1459821374834; Mon, 04 Apr 2016 18:56:14 -0700 (PDT) Received: from xeon-e3 (static-50-53-71-109.bvtn.or.frontiernet.net. [50.53.71.109]) by smtp.gmail.com with ESMTPSA id xs10sm3244123pab.4.2016.04.04.18.56.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Apr 2016 18:56:14 -0700 (PDT) Date: Mon, 4 Apr 2016 18:56:26 -0700 From: Stephen Hemminger To: "Lu, Wenzhuo" Cc: "Zhang, Helin" , "Ananyev, Konstantin" , "dev@dpdk.org" Message-ID: <20160404185626.26c4b1fe@xeon-e3> In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09090344188F@shsmsx102.ccr.corp.intel.com> References: <1459786443-27501-1-git-send-email-stephen@networkplumber.org> <6A0DE07E22DDAD4C9103DF62FEBC09090344188F@shsmsx102.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] ixgbe: cleanup whitespace and formatting issues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Apr 2016 01:56:16 -0000 On Tue, 5 Apr 2016 00:57:16 +0000 "Lu, Wenzhuo" wrote: > Hi Stephen, > > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen Hemminger > > Sent: Tuesday, April 5, 2016 12:14 AM > > To: Zhang, Helin; Ananyev, Konstantin > > Cc: dev@dpdk.org; Stephen Hemminger > > Subject: [dpdk-dev] [PATCH] ixgbe: cleanup whitespace and formatting issues > > > > This driver was one of the originals and has lots of little whitespace issues. > > > > PS: I know Intel doesn't like whitespace changes, there is never a good time > > to do this, but no resuliting binary changes and it is unlikely that more > > changes to this driver will occur this late in release cycle. > > > > Signed-off-by: Stephen Hemminger > Thanks for this patch. I think it's good to make the format better :) > But there's some checkpatch error and warnings, like this, > ERROR: "foo* bar" should be "foo *bar" > #508: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:4256: > +ixgbe_uc_hash_table_set(struct rte_eth_dev *dev, struct ether_addr* mac_addr, > I didn't fix all the checkpatch errors, just the easy ones.