From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: "Tan, Jianfeng" <jianfeng.tan@intel.com>
Cc: Rich Lane <rich.lane@bigswitch.com>,
dev@dpdk.org, Huawei Xie <huawei.xie@intel.com>,
Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [dpdk-dev] [PATCH v2] virtio: use zeroed memory for simple TX header
Date: Tue, 5 Apr 2016 12:26:54 +0800 [thread overview]
Message-ID: <20160405042654.GN3080@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <57032EE5.4050408@intel.com>
On Tue, Apr 05, 2016 at 11:20:05AM +0800, Tan, Jianfeng wrote:
> Hi,
>
> On 4/5/2016 10:11 AM, Rich Lane wrote:
> >For simple TX the virtio-net header must be zeroed, but it was using memory
> >that had been initialized with indirect descriptor tables. This resulted in
> >"unsupported gso type" errors from librte_vhost.
> >
> >We can use the same memory for every descriptor to save cachelines in the
> >vswitch.
>
> Pointing all virtio_net_hdr into the same memory may brings performance, but
> how much? It also introduces difficulty to adding tso in future?
simple rxtx will not be enabled when TSO is enabled.
--yliu
next prev parent reply other threads:[~2016-04-05 4:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-05 2:11 Rich Lane
2016-04-05 3:20 ` Tan, Jianfeng
2016-04-05 4:26 ` Yuanhan Liu [this message]
2016-04-05 5:34 ` Tan, Jianfeng
2016-04-05 4:25 ` Yuanhan Liu
2016-04-06 10:28 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160405042654.GN3080@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=dev@dpdk.org \
--cc=huawei.xie@intel.com \
--cc=jianfeng.tan@intel.com \
--cc=rich.lane@bigswitch.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).