From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <viktorin@rehivetech.com>
Received: from wes1-so1.wedos.net (wes1-so1.wedos.net [46.28.106.15])
 by dpdk.org (Postfix) with ESMTP id 15F532C08
 for <dev@dpdk.org>; Wed,  6 Apr 2016 14:10:26 +0200 (CEST)
Received: from pcviktorin.fit.vutbr.cz (pcviktorin.fit.vutbr.cz
 [147.229.13.147])
 by wes1-so1.wedos.net (Postfix) with ESMTPSA id 3qg4L94mbSz5qw;
 Wed,  6 Apr 2016 14:10:25 +0200 (CEST)
Date: Wed, 6 Apr 2016 14:10:46 +0200
From: "Jan Viktorin" <viktorin@rehivetech.com>
To: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>, Thomas
 Monjalon <thomas.monjalon@6wind.com>
Message-ID: <20160406141046.0e5bd205@pcviktorin.fit.vutbr.cz>
In-Reply-To: <20160406085414.GE28696@6wind.com>
References: <1459865290-10248-8-git-send-email-adrien.mazarguil@6wind.com>
 <20160405222304.20a38b6d@pcviktorin.fit.vutbr.cz>
 <20160406085414.GE28696@6wind.com>
Organization: RehiveTech
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [dpdk-dev,
	07/10] lib: fix missing include dependencies
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Apr 2016 12:10:26 -0000

On Wed, 6 Apr 2016 10:54:14 +0200
Adrien Mazarguil <adrien.mazarguil@6wind.com> wrote:

> Hi Jan,
> 
> Replying below as well.
> 
[...]
> > > --- a/lib/librte_eal/common/include/arch/arm/rte_byteorder.h
> > > +++ b/lib/librte_eal/common/include/arch/arm/rte_byteorder.h
> > > @@ -37,6 +37,9 @@
> > >  #  error Platform must be built with CONFIG_RTE_FORCE_INTRINSICS
> > >  #endif
> > >  
> > > +#include <stdint.h>
> > > +#include <rte_common.h>  
> > 
> > Why not to place it into the extern "C" { block? There is already:
> > 
> > #include "generic/rte_byteorder.h"  
> 
> Right, I did not do it because headers may eventually contain C++
> compatibility code someday, so I think we should avoid #includes inside
> extern "C" blocks. C++ compliant headers should provide their own blocks,
> also I'm not sure how well it mixes with system includes having their own
> compatibility layer.
> 
> I agree we need consistency, so what about a commit to move all #includes
> outside of such blocks instead?

Yes, I agree.

> 
> > > +#include <rte_common.h>  
> > 
> > I don't see any reason for this. The header does not use anything
> > special. Just "asm", but that should be a keyword...  
> 
> Unfortunately it's a nonstandard keyword which is defined as __asm__ in
> rte_common.h, itself an extension keyword compilers will swallow without
> complaining thanks to these "__".

OK.

> 
> > >  #ifdef __cplusplus
> > >  extern "C" {
> > >  #endif
> > > diff --git a/lib/librte_eal/common/include/arch/arm/rte_prefetch_64.h b/lib/librte_eal/common/include/arch/arm/rte_prefetch_64.h
> > > index 3ed46a4..600c6f0 100644
> > > --- a/lib/librte_eal/common/include/arch/arm/rte_prefetch_64.h
> > > +++ b/lib/librte_eal/common/include/arch/arm/rte_prefetch_64.h
> > > @@ -33,6 +33,8 @@
> > >  #ifndef _RTE_PREFETCH_ARM_64_H_
> > >  #define _RTE_PREFETCH_ARM_64_H_
> > >  
> > > +#include <rte_common.h>  
> > 
> > Same here.  
> 
> Same reason here.

OK.

Regards
Jan