From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Tetsuya Mukawa <mukawa@igel.co.jp>
Cc: Thomas Monjalon <thomas.monjalon@6wind.com>,
Rich Lane <rich.lane@bigswitch.com>,
dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] vhost: call rte_vhost_enable_guest_notification only on enabled queues
Date: Fri, 8 Apr 2016 14:14:58 +0800 [thread overview]
Message-ID: <20160408061458.GF3080@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <57070D3D.2070700@igel.co.jp>
On Fri, Apr 08, 2016 at 10:45:33AM +0900, Tetsuya Mukawa wrote:
> On 2016/04/08 2:20, Thomas Monjalon wrote:
> >>> If the vhost PMD were configured with more queues than the guest, the old
> >>> code would segfault in rte_vhost_enable_guest_notification due to a NULL
> >>> virtqueue pointer.
> >>>
> >>> Fixes: ee584e9710b9 ("vhost: add driver on top of the library")
> >>> Signed-off-by: Rich Lane <rich.lane@bigswitch.com>
> >> Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
> > Applied, thanks
>
> Hi Rich and Yuanhan,
>
> I am sorry for late reply. I was out of office yesterday.
Tetsuya, no worry! Man takes leaves, and isn't the reason we have 2 or
more maintainers on some blocks? :)
--yliu
> I've tested it also today, and seems to be good.
>
> Thanks,
> Tetsuya
next prev parent reply other threads:[~2016-04-08 6:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 0:29 Rich Lane
2016-04-07 10:40 ` Loftus, Ciara
2016-04-07 11:48 ` Tan, Jianfeng
2016-04-07 15:29 ` Loftus, Ciara
2016-04-07 15:42 ` Yuanhan Liu
2016-04-07 16:13 ` Tan, Jianfeng
2016-04-07 15:42 ` Yuanhan Liu
2016-04-07 17:20 ` Thomas Monjalon
2016-04-08 1:45 ` Tetsuya Mukawa
2016-04-08 6:14 ` Yuanhan Liu [this message]
2016-04-08 7:03 ` Tetsuya Mukawa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160408061458.GF3080@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=dev@dpdk.org \
--cc=mukawa@igel.co.jp \
--cc=rich.lane@bigswitch.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).