From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id B027B2C0C for ; Tue, 19 Apr 2016 15:02:24 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP; 19 Apr 2016 06:01:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,506,1455004800"; d="scan'208";a="87941919" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.220.132]) by fmsmga004.fm.intel.com with SMTP; 19 Apr 2016 06:01:46 -0700 Received: by (sSMTP sendmail emulation); Tue, 19 Apr 2016 14:01:43 +0025 Date: Tue, 19 Apr 2016 14:01:43 +0100 From: Bruce Richardson To: Stephen Hurd Cc: dev@dpdk.org, Thomas Monjalon Message-ID: <20160419130143.GB15456@bricha3-MOBL3> References: <1456978137-98097-1-git-send-email-stephen.hurd@broadcom.com> <1457125528-128877-3-git-send-email-stephen.hurd@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1457125528-128877-3-git-send-email-stephen.hurd@broadcom.com> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v3 2/7] lib/librte_eal: Add PCI IDs for Broadcom bnxt X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Apr 2016 13:02:25 -0000 On Fri, Mar 04, 2016 at 01:05:23PM -0800, Stephen Hurd wrote: > Add Broadcom Vendor ID and RTE_PCI_DEV_ID_DECL_BNXT() macro. > Add Device IDs for Broadcom bnxt devices. > > Signed-off-by: Stephen Hurd > --- > lib/librte_eal/common/include/rte_pci_dev_ids.h | 45 ++++++++++++++++++++++--- > 1 file changed, 40 insertions(+), 5 deletions(-) > > diff --git a/lib/librte_eal/common/include/rte_pci_dev_ids.h b/lib/librte_eal/common/include/rte_pci_dev_ids.h > index d088191..9a8f254 100644 > --- a/lib/librte_eal/common/include/rte_pci_dev_ids.h > +++ b/lib/librte_eal/common/include/rte_pci_dev_ids.h > @@ -63,11 +63,11 @@ > * This file contains a list of the PCI device IDs recognised by DPDK, which > * can be used to fill out an array of structures describing the devices. > * > - * Currently four families of devices are recognised: those supported by the > - * IGB driver, by EM driver, those supported by the IXGBE driver, and by virtio > - * driver which is a para virtualization driver running in guest virtual machine. > - * The inclusion of these in an array built using this file depends on the > - * definition of > + * Currently five families of devices are recognised: those supported by the > + * IGB driver, by EM driver, those supported by the IXGBE driver, by BNXT > + * driver, and by virtio driver which is a para virtualization driver running > + * in guest virtual machine. The inclusion of these in an array built using > + * this file depends on the definition of > * RTE_PCI_DEV_ID_DECL_EM > * RTE_PCI_DEV_ID_DECL_IGB > * RTE_PCI_DEV_ID_DECL_IGBVF > @@ -76,6 +76,7 @@ > * RTE_PCI_DEV_ID_DECL_I40E > * RTE_PCI_DEV_ID_DECL_I40EVF > * RTE_PCI_DEV_ID_DECL_VIRTIO > + * RTE_PCI_DEV_ID_DECL_BNXT > * at the time when this file is included. > * > * In order to populate an array, the user of this file must define this macro: > @@ -167,6 +168,15 @@ > #define PCI_VENDOR_ID_VMWARE 0x15AD > #endif > > +#ifndef PCI_VENDOR_ID_BROADCOM > +/** Vendor ID used by Broadcom devices */ > +#define PCI_VENDOR_ID_BROADCOM 0x14E4 > +#endif > + > +#ifndef RTE_PCI_DEV_ID_DECL_BNXT > +#define RTE_PCI_DEV_ID_DECL_BNXT(vendor, dev) > +#endif > + This macro definition looks to be in the wrong place in the file. The device definitions are all placed above the vendor declarations. /Bruce