Re: [dpdk-dev] [PATCH v3 3/7] drivers/net/bnxt new driver for Broadcom bnxt

[Bruce Richardson <bruce.richardson@intel.com>]

On Tue, Apr 19, 2016 at 01:51:32PM -0700, Stephen Hurd wrote:
> On Tue, Apr 19, 2016 at 7:19 AM, Bruce Richardson <
> bruce.richardson@intel.com> wrote:
> 
> > On Fri, Mar 04, 2016 at 01:05:24PM -0800, Stephen Hurd wrote:
> > > New driver for Broadcom bnxt (NexXtreme C-series) devices.
> >
> > This seems a single huge commit. Can this be split up into separate commits
> > with self-contained changes in each one, e.g. a feature per commit,
> > starting
> > with basic init, then RX and TX etc. etc.?
> >
> 
> I suppose it could, I'm not sure what the value of that approach would be
> though... it would just be a long process of copy/paste/commit/repeat.
> Internally, it was developed as a port/rewrite of another driver, so we
> don't actually have history without a large commit.
> 
> Assuming each individual commit needs to be buildable, this will end up
> burning a lot of time, and I doubt each separate commit could be reasonably
> tested.
> 
> 
It's not for testing, more for code review and to help understand the code [though
as you say, we do need to ensure that each commit doesn't actually break the 
build]. 
Right now, the driver code goes in as a single commit - which makes it a hard
enough task to review and see what is in there. One suggestion that hopefully
wouldn't be too much work might be to split the code up into: basic device
init code, RX and TX functions, and then any additional features based on top
of that [ideally one patch per added feature].

Regards,
/Bruce