From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 45A8B2BF2 for ; Thu, 21 Apr 2016 12:00:10 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP; 21 Apr 2016 03:00:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,512,1455004800"; d="scan'208";a="937108922" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.220.132]) by orsmga001.jf.intel.com with SMTP; 21 Apr 2016 03:00:06 -0700 Received: by (sSMTP sendmail emulation); Thu, 21 Apr 2016 11:00:05 +0025 Date: Thu, 21 Apr 2016 11:00:05 +0100 From: Bruce Richardson To: Stephen Hurd Cc: Ajit Kumar Khaparde , dev@dpdk.org, Thomas Monjalon Message-ID: <20160421100005.GA976@bricha3-MOBL3> References: <1456978137-98097-1-git-send-email-stephen.hurd@broadcom.com> <1457125528-128877-4-git-send-email-stephen.hurd@broadcom.com> <20160419141933.GC15456@bricha3-MOBL3> <20160420110107.GA11120@bricha3-MOBL3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v3 3/7] drivers/net/bnxt new driver for Broadcom bnxt X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Apr 2016 10:00:10 -0000 On Wed, Apr 20, 2016 at 02:32:18PM -0700, Stephen Hurd wrote: > > It's not for testing, more for code review and to help understand the code > > [though > > as you say, we do need to ensure that each commit doesn't actually break > > the > > build]. > > Right now, the driver code goes in as a single commit - which makes it a > > hard > > enough task to review and see what is in there. One suggestion that > > hopefully > > wouldn't be too much work might be to split the code up into: basic device > > init code, RX and TX functions, and then any additional features based on > > top > > of that [ideally one patch per added feature]. > > > > The current driver doesn't have much beyond basic TX/RX, but we can give it > a shot. "Too much work" is relative of course, but splitting it into > self-contained easily understood chunks will absolutely be a lot of work. > > Adding Ajit who will also be working on this. Since he's coming up to > speed on the driver code, this could be a good way for him to fully > familiarize himself with it. > Sure, thanks. Any splitting you can do at all would be appreciated and help with reviews. /Bruce