From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wes1-so2.wedos.net (wes1-so2.wedos.net [46.28.106.16]) by dpdk.org (Postfix) with ESMTP id 32C752A5D for ; Fri, 22 Apr 2016 12:20:30 +0200 (CEST) Received: from pcviktorin.fit.vutbr.cz (pcviktorin.fit.vutbr.cz [147.229.13.147]) by wes1-so2.wedos.net (Postfix) with ESMTPSA id 3qrs7x4q1mz8R7; Fri, 22 Apr 2016 12:20:29 +0200 (CEST) Date: Fri, 22 Apr 2016 12:18:26 +0200 From: Jan Viktorin To: David Marchand Cc: Bruce Richardson , dev@dpdk.org, thomas.monjalon@6wind.com Message-ID: <20160422121826.20374855@pcviktorin.fit.vutbr.cz> In-Reply-To: <20160420144118.16003a63@pcviktorin.fit.vutbr.cz> References: <1454076516-21591-1-git-send-email-david.marchand@6wind.com> <1461152657-19969-1-git-send-email-david.marchand@6wind.com> <20160420120524.GA2020@bricha3-MOBL3> <20160420144118.16003a63@pcviktorin.fit.vutbr.cz> Organization: RehiveTech MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 00/17] prepare for rte_device / rte_driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Apr 2016 10:20:30 -0000 [...] > > > > > > Changes since v1: > > > - rebased on HEAD, new drivers should be okay > > > - patches have been split into smaller pieces > > > - RTE_INIT macro has been added, but in the end, I am not sure it is useful > > > - device type has been removed from ethdev, as it was used only by hotplug > > > - getting rid of pmd type in eal patch (patch 5 of initial series) has been > > > dropped for now, we can do this once vdev drivers have been converted > > > > > > [1] http://dpdk.org/ml/archives/dev/2016-January/031390.html > > > > > > Regards, > > > -- > > > David Marchand > > > > > Nice, David. Looks to be some good improvements in there! > > > > /Bruce > > Looks good for me but I've failed to apply the series on top of > > commit 7d619406f31ddf115714b32778c33f6dc0ead470 > Author: Thomas Monjalon > Date: Thu Apr 14 20:49:49 2016 +0200 > > pci: remove deprecated specific config OK, it works, my fault. What is the way of removing the pmd_type? Would you like to introduce something like rte_virt_device/driver pair for this purpose? Or should they use the rte_device/rte_driver directly? Other points: * The devinit/devuninit should be generalized and moved to rte_driver, right? * Fields name, drv_flags should be moved to rte_driver. * Fields devargs, intr_handle, numa_node should be moved to rte_device. * Do we want getter/setters for those? Otherwise, it always looks like pci_dev->dev.numa_node. * What about pci_driver_list and pci_device_list? Should we have separated lists for every kind of device + driver? or should there be a single list (and so we have to put some discriminator into the rte_device/driver)? This influences placing of the TAILQ_ENTRY(...) next. * if we move the next into the rte_driver/device and a discriminator of their type there, all TAILQ_FOREACH loops will look ugly as we have to check the discriminator... Regards Jan > > Jan -- Jan Viktorin E-mail: Viktorin@RehiveTech.com System Architect Web: www.RehiveTech.com RehiveTech Brno, Czech Republic