DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Rasesh Mody <rasesh.mody@qlogic.com>
Cc: thomas.monjalon@6wind.com, dev@dpdk.org, ameen.rahman@qlogic.com,
	Harish Patil <harish.patil@qlogic.com>,
	Sony Chacko <sony.chacko@qlogic.com>
Subject: Re: [dpdk-dev] [PATCH v6 2/8] qede: Add base driver
Date: Tue, 26 Apr 2016 14:16:34 +0100	[thread overview]
Message-ID: <20160426131634.GC6992@bricha3-MOBL3> (raw)
In-Reply-To: <1461647586-22234-2-git-send-email-rasesh.mody@qlogic.com>

On Mon, Apr 25, 2016 at 10:13:00PM -0700, Rasesh Mody wrote:
> The base driver is the backend module for the QLogic FastLinQ QL4xxxx
> 25G/40G CNA family of adapters as well as their virtual functions (VF)
> in SR-IOV context.
> 
> The purpose of the base module is to:
>  - provide all the common code that will be shared between the various
>    drivers that would be used with said line of products. Flows such as
>    chip initialization and de-initialization fall under this category.
>  - abstract the protocol-specific HW & FW components, allowing the
>    protocol drivers to have clean APIs, which are detached in its
>    slowpath configuration from the actual Hardware Software Interface(HSI).
> 
> This patch adds a base module without any protocol-specific bits.
> I.e., this adds a basic implementation that almost entirely falls under
> the first category.
> 
> Signed-off-by: Harish Patil <harish.patil@qlogic.com>
> Signed-off-by: Rasesh Mody <rasesh.mody@qlogic.com>
> Signed-off-by: Sony Chacko <sony.chacko@qlogic.com>
> ---

Checkpatch complains about a few things when I run it, notably this typo:

WARNING:TYPO_SPELLING: 'DIDNT' may be misspelled - perhaps 'DIDN'T'?
#13900: FILE: drivers/net/qede/base/ecore_hsi_tools.h:913:
+       DBG_STATUS_DATA_DIDNT_TRIGGER,

and a few complaints about:

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#223: FILE: drivers/net/qede/base/bcm_osal.c:90:
+       unsigned socket_id;

Regards,
/Bruce

  parent reply	other threads:[~2016-04-26 13:16 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-26  5:12 [dpdk-dev] [PATCH v6 1/8] qede: Add maintainers, documentation and license Rasesh Mody
2016-04-26  5:13 ` [dpdk-dev] [PATCH v6 2/8] qede: Add base driver Rasesh Mody
2016-04-26 13:01   ` Bruce Richardson
2016-04-27  0:49     ` Rasesh Mody
2016-04-26 13:16   ` Bruce Richardson [this message]
2016-04-26  5:13 ` [dpdk-dev] [PATCH v6 3/8] qede: Add core driver Rasesh Mody
2016-04-26  5:13 ` [dpdk-dev] [PATCH v6 4/8] qede: Add L2 support Rasesh Mody
2016-04-26  5:13 ` [dpdk-dev] [PATCH v6 5/8] qede: Add SRIOV support Rasesh Mody
2016-04-26  5:13 ` [dpdk-dev] [PATCH v6 6/8] qede: Add attention support Rasesh Mody
2016-04-26 13:25   ` Bruce Richardson
2016-04-26  5:13 ` [dpdk-dev] [PATCH v6 7/8] qede: Add DCBX support Rasesh Mody
2016-04-26  5:13 ` [dpdk-dev] [PATCH v6 8/8] qede: Enable PMD build Rasesh Mody
2016-04-26 14:56   ` Bruce Richardson
2016-04-26 13:03 ` [dpdk-dev] [PATCH v6 1/8] qede: Add maintainers, documentation and license Bruce Richardson
2016-04-26 18:27   ` Rasesh Mody
2016-04-26 19:33     ` Thomas Monjalon
2016-04-26 19:35       ` Rasesh Mody
2016-04-26 15:04 ` Bruce Richardson
2016-04-26 15:19   ` Mcnamara, John
2016-04-26 15:40     ` Thomas Monjalon
2016-04-26 15:49 ` Mcnamara, John
2016-04-27  0:21   ` Rasesh Mody

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160426131634.GC6992@bricha3-MOBL3 \
    --to=bruce.richardson@intel.com \
    --cc=ameen.rahman@qlogic.com \
    --cc=dev@dpdk.org \
    --cc=harish.patil@qlogic.com \
    --cc=rasesh.mody@qlogic.com \
    --cc=sony.chacko@qlogic.com \
    --cc=thomas.monjalon@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).