From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 44EED3208 for ; Tue, 26 Apr 2016 15:16:38 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP; 26 Apr 2016 06:16:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,536,1455004800"; d="scan'208";a="692485194" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.45]) by FMSMGA003.fm.intel.com with SMTP; 26 Apr 2016 06:16:35 -0700 Received: by (sSMTP sendmail emulation); Tue, 26 Apr 2016 14:16:34 +0025 Date: Tue, 26 Apr 2016 14:16:34 +0100 From: Bruce Richardson To: Rasesh Mody Cc: thomas.monjalon@6wind.com, dev@dpdk.org, ameen.rahman@qlogic.com, Harish Patil , Sony Chacko Message-ID: <20160426131634.GC6992@bricha3-MOBL3> References: <1461647586-22234-1-git-send-email-rasesh.mody@qlogic.com> <1461647586-22234-2-git-send-email-rasesh.mody@qlogic.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1461647586-22234-2-git-send-email-rasesh.mody@qlogic.com> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v6 2/8] qede: Add base driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Apr 2016 13:16:38 -0000 On Mon, Apr 25, 2016 at 10:13:00PM -0700, Rasesh Mody wrote: > The base driver is the backend module for the QLogic FastLinQ QL4xxxx > 25G/40G CNA family of adapters as well as their virtual functions (VF) > in SR-IOV context. > > The purpose of the base module is to: > - provide all the common code that will be shared between the various > drivers that would be used with said line of products. Flows such as > chip initialization and de-initialization fall under this category. > - abstract the protocol-specific HW & FW components, allowing the > protocol drivers to have clean APIs, which are detached in its > slowpath configuration from the actual Hardware Software Interface(HSI). > > This patch adds a base module without any protocol-specific bits. > I.e., this adds a basic implementation that almost entirely falls under > the first category. > > Signed-off-by: Harish Patil > Signed-off-by: Rasesh Mody > Signed-off-by: Sony Chacko > --- Checkpatch complains about a few things when I run it, notably this typo: WARNING:TYPO_SPELLING: 'DIDNT' may be misspelled - perhaps 'DIDN'T'? #13900: FILE: drivers/net/qede/base/ecore_hsi_tools.h:913: + DBG_STATUS_DATA_DIDNT_TRIGGER, and a few complaints about: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #223: FILE: drivers/net/qede/base/bcm_osal.c:90: + unsigned socket_id; Regards, /Bruce