Re: [dpdk-dev] [PATCH v6 6/8] qede: Add attention support

[Bruce Richardson <bruce.richardson@intel.com>]

On Mon, Apr 25, 2016 at 10:13:04PM -0700, Rasesh Mody wrote:
> Physical link is handled by the management Firmware.
> This patch lays the infrastructure for attention handling in the driver,
> as link change notifications arrive via async attentions, as well as the
> handling of such notifications. It adds async event notification handler
> interfaces to the PMD.
> 
> Signed-off-by: Harish Patil <harish.patil@qlogic.com>
> Signed-off-by: Rasesh Mody <rasesh.mody@qlogic.com>
> Signed-off-by: Sony Chacko <sony.chacko@qlogic.com>
> ---
>  drivers/net/qede/base/ecore_attn_values.h |13287 +++++++++++++++++++++++++++++
>  drivers/net/qede/base/ecore_dev.c         |   51 +
>  drivers/net/qede/base/ecore_int.c         | 1131 +++
>  3 files changed, 14469 insertions(+)
>  create mode 100644 drivers/net/qede/base/ecore_attn_values.h
> 
I'm not familiar with the term "attentions" or "attention handling". 
Would "interrupt handling" or "async event handling" not be better to use in the
title and commit message to make things more unstandable to readers.

If you do want to use the term attentions in the commit message body, please
explain the term first. [I don't believe the term should be used in the commit
title, though]

Regards,
/Bruce