From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 42987DE0 for ; Tue, 26 Apr 2016 15:25:49 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP; 26 Apr 2016 06:25:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,536,1455004800"; d="scan'208";a="92178293" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.45]) by fmsmga004.fm.intel.com with SMTP; 26 Apr 2016 06:25:34 -0700 Received: by (sSMTP sendmail emulation); Tue, 26 Apr 2016 14:25:33 +0025 Date: Tue, 26 Apr 2016 14:25:33 +0100 From: Bruce Richardson To: Rasesh Mody Cc: thomas.monjalon@6wind.com, dev@dpdk.org, ameen.rahman@qlogic.com, Harish Patil , Sony Chacko Message-ID: <20160426132533.GA10896@bricha3-MOBL3> References: <1461647586-22234-1-git-send-email-rasesh.mody@qlogic.com> <1461647586-22234-6-git-send-email-rasesh.mody@qlogic.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1461647586-22234-6-git-send-email-rasesh.mody@qlogic.com> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v6 6/8] qede: Add attention support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Apr 2016 13:25:49 -0000 On Mon, Apr 25, 2016 at 10:13:04PM -0700, Rasesh Mody wrote: > Physical link is handled by the management Firmware. > This patch lays the infrastructure for attention handling in the driver, > as link change notifications arrive via async attentions, as well as the > handling of such notifications. It adds async event notification handler > interfaces to the PMD. > > Signed-off-by: Harish Patil > Signed-off-by: Rasesh Mody > Signed-off-by: Sony Chacko > --- > drivers/net/qede/base/ecore_attn_values.h |13287 +++++++++++++++++++++++++++++ > drivers/net/qede/base/ecore_dev.c | 51 + > drivers/net/qede/base/ecore_int.c | 1131 +++ > 3 files changed, 14469 insertions(+) > create mode 100644 drivers/net/qede/base/ecore_attn_values.h > I'm not familiar with the term "attentions" or "attention handling". Would "interrupt handling" or "async event handling" not be better to use in the title and commit message to make things more unstandable to readers. If you do want to use the term attentions in the commit message body, please explain the term first. [I don't believe the term should be used in the commit title, though] Regards, /Bruce