* [dpdk-dev] [PATCH] virtio: check if virtio net header could fit in mbuf headroom
@ 2016-04-25 14:21 Huawei Xie
2016-04-26 16:51 ` Yuanhan Liu
2016-04-26 23:27 ` [dpdk-dev] [PATCH v2] " Huawei Xie
0 siblings, 2 replies; 4+ messages in thread
From: Huawei Xie @ 2016-04-25 14:21 UTC (permalink / raw)
To: dev; +Cc: yuanhan.liu, stephen
check merge-able header as it is supported.
previously we don't support merge-able feature, so non merge-able
header is checked.
---
drivers/net/virtio/virtio_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
index 63a368a..20ff03e 100644
--- a/drivers/net/virtio/virtio_ethdev.c
+++ b/drivers/net/virtio/virtio_ethdev.c
@@ -1036,7 +1036,7 @@ eth_virtio_dev_init(struct rte_eth_dev *eth_dev)
struct rte_pci_device *pci_dev;
int ret;
- RTE_BUILD_BUG_ON(RTE_PKTMBUF_HEADROOM < sizeof(struct virtio_net_hdr));
+ RTE_BUILD_BUG_ON(RTE_PKTMBUF_HEADROOM < sizeof(struct virtio_net_hdr_mrg_rxbuf));
eth_dev->dev_ops = &virtio_eth_dev_ops;
eth_dev->tx_pkt_burst = &virtio_xmit_pkts;
--
1.8.1.4
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] virtio: check if virtio net header could fit in mbuf headroom
2016-04-25 14:21 [dpdk-dev] [PATCH] virtio: check if virtio net header could fit in mbuf headroom Huawei Xie
@ 2016-04-26 16:51 ` Yuanhan Liu
2016-04-26 23:27 ` [dpdk-dev] [PATCH v2] " Huawei Xie
1 sibling, 0 replies; 4+ messages in thread
From: Yuanhan Liu @ 2016-04-26 16:51 UTC (permalink / raw)
To: Huawei Xie; +Cc: dev
On Mon, Apr 25, 2016 at 10:21:32PM +0800, Huawei Xie wrote:
> check merge-able header as it is supported.
> previously we don't support merge-able feature, so non merge-able
> header is checked.
Signed-off-by is missing here. Otherwise, this patch looks good to me
--yliu
^ permalink raw reply [flat|nested] 4+ messages in thread
* [dpdk-dev] [PATCH v2] virtio: check if virtio net header could fit in mbuf headroom
2016-04-25 14:21 [dpdk-dev] [PATCH] virtio: check if virtio net header could fit in mbuf headroom Huawei Xie
2016-04-26 16:51 ` Yuanhan Liu
@ 2016-04-26 23:27 ` Huawei Xie
2016-04-27 22:11 ` Yuanhan Liu
1 sibling, 1 reply; 4+ messages in thread
From: Huawei Xie @ 2016-04-26 23:27 UTC (permalink / raw)
To: dev; +Cc: yuanhan.liu, stephen, Huawei Xie
check merge-able header as it is supported.
previously we don't support merge-able feature, so non merge-able
header is checked.
v2:
add missed signoff
Signed-off-by: Huawei Xie <huawei.xie@intel.com>
---
drivers/net/virtio/virtio_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
index 63a368a..20ff03e 100644
--- a/drivers/net/virtio/virtio_ethdev.c
+++ b/drivers/net/virtio/virtio_ethdev.c
@@ -1036,7 +1036,7 @@ eth_virtio_dev_init(struct rte_eth_dev *eth_dev)
struct rte_pci_device *pci_dev;
int ret;
- RTE_BUILD_BUG_ON(RTE_PKTMBUF_HEADROOM < sizeof(struct virtio_net_hdr));
+ RTE_BUILD_BUG_ON(RTE_PKTMBUF_HEADROOM < sizeof(struct virtio_net_hdr_mrg_rxbuf));
eth_dev->dev_ops = &virtio_eth_dev_ops;
eth_dev->tx_pkt_burst = &virtio_xmit_pkts;
--
1.8.1.4
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH v2] virtio: check if virtio net header could fit in mbuf headroom
2016-04-26 23:27 ` [dpdk-dev] [PATCH v2] " Huawei Xie
@ 2016-04-27 22:11 ` Yuanhan Liu
0 siblings, 0 replies; 4+ messages in thread
From: Yuanhan Liu @ 2016-04-27 22:11 UTC (permalink / raw)
To: Huawei Xie; +Cc: dev
On Wed, Apr 27, 2016 at 07:27:55AM +0800, Huawei Xie wrote:
> check merge-able header as it is supported.
> previously we don't support merge-able feature, so non merge-able
> header is checked.
>
> v2:
> add missed signoff
Applied to dpdk-next-virtio with above version log removed: DPDK
prefers to put it below the SoB, so that it will not be in git
history.
Thanks.
--yliu
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-04-27 22:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-25 14:21 [dpdk-dev] [PATCH] virtio: check if virtio net header could fit in mbuf headroom Huawei Xie
2016-04-26 16:51 ` Yuanhan Liu
2016-04-26 23:27 ` [dpdk-dev] [PATCH v2] " Huawei Xie
2016-04-27 22:11 ` Yuanhan Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).