From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yuanhan.liu@linux.intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 92743530C
 for <dev@dpdk.org>; Thu, 28 Apr 2016 05:26:57 +0200 (CEST)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by fmsmga103.fm.intel.com with ESMTP; 27 Apr 2016 20:26:56 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.24,545,1455004800"; d="scan'208";a="693499778"
Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162])
 by FMSMGA003.fm.intel.com with ESMTP; 27 Apr 2016 20:26:55 -0700
Date: Wed, 27 Apr 2016 20:29:30 -0700
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: "Tan, Jianfeng" <jianfeng.tan@intel.com>
Cc: dev@dpdk.org, huawei.xie@intel.com
Message-ID: <20160428032930.GA11064@yliu-dev.sh.intel.com>
References: <1461673932-128879-1-git-send-email-jianfeng.tan@intel.com>
 <20160427223753.GB25677@yliu-dev.sh.intel.com>
 <f4b68de5-d88c-d6b8-04fa-48762b301a4b@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f4b68de5-d88c-d6b8-04fa-48762b301a4b@intel.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] [PATCH] virtio: fix memory leak of virtqueue memzones
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 28 Apr 2016 03:26:58 -0000

On Thu, Apr 28, 2016 at 10:01:06AM +0800, Tan, Jianfeng wrote:
> >>+
> >>+	snprintf(vq_name, sizeof(vq_name), "port%d_%s%d",
> >>+		 dev->data->port_id, queue_names[queue_type], queue_idx);
> >>+	vq = rte_zmalloc(vq_name, sizeof(struct virtqueue) +
> >>+			 vq_size * sizeof(struct vq_desc_extra),
> >>+			 RTE_CACHE_LINE_SIZE);
> >This is a cleanup, a good cleanup. So, make a patch for that, and do
> >NOT mix cleanup and fix in one single patch, which is something I
> >have told you quite few times, right?
> 
> You mean submit a specific patch for cleanup or just another commit inside
> this patch set?

Do it as a patchset, as the two are connected: the fix should be based
on the cleanup patch.

	--yliu