From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Huawei Xie <huawei.xie@intel.com>
Cc: dev@dpdk.org, stephen@networkplumber.org, mukawa@igel.co.jp,
kevin.traynor@intel.com, jianfeng.tan@intel.com
Subject: Re: [dpdk-dev] [PATCH] virtio: avoid avail ring entry index update if equal
Date: Wed, 27 Apr 2016 23:19:31 -0700 [thread overview]
Message-ID: <20160428061931.GH25677@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <1461747238-124446-1-git-send-email-huawei.xie@intel.com>
On Wed, Apr 27, 2016 at 04:53:58AM -0400, Huawei Xie wrote:
> Avail ring is updated by the frontend and consumed by the backend.
> There are frequent core to core cache transfers for the avail ring.
>
> This optmization avoids avail ring entry index update if the entry
> already holds the same value.
> As DPDK virtio PMD implements FIFO free descriptor list (also for
> performance reason of CACHE), in which descriptors are allocated
> from the head and freed to the tail, with this patch in most cases
> avail ring will remain the same, then it would be valid in both caches
> of frontend and backend.
Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
>
> Signed-off-by: Huawei Xie <huawei.xie@intel.com>
> Suggested-by: ms >> Michael S. Tsirkin <mst@redhat.com>
And applied to dpdk-next-virtio, with few tiny changes:
- we normally put suggested/reported-by above the SoB.
- removed "ms >>"
Thanks.
--yliu
next prev parent reply other threads:[~2016-04-28 6:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-21 17:18 [dpdk-dev] [RFC PATCH] avail idx update optimizations Huawei Xie
[not found] ` <C37D651A908B024F974696C65296B57B4C713327@SHSMSX101.ccr.corp.intel.com>
2016-04-24 2:45 ` Xie, Huawei
2016-04-24 9:15 ` Michael S. Tsirkin
2016-04-24 13:23 ` Xie, Huawei
2016-04-28 9:17 ` Xie, Huawei
2016-04-27 8:53 ` [dpdk-dev] [PATCH] virtio: avoid avail ring entry index update if equal Huawei Xie
2016-04-28 6:19 ` Yuanhan Liu [this message]
2016-04-28 8:14 ` Thomas Monjalon
2016-04-28 13:15 ` Xie, Huawei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160428061931.GH25677@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=dev@dpdk.org \
--cc=huawei.xie@intel.com \
--cc=jianfeng.tan@intel.com \
--cc=kevin.traynor@intel.com \
--cc=mukawa@igel.co.jp \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).