From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 257175598 for ; Thu, 28 Apr 2016 22:15:07 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP; 28 Apr 2016 13:12:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,548,1455004800"; d="scan'208";a="794516805" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by orsmga003.jf.intel.com with ESMTP; 28 Apr 2016 13:12:32 -0700 Date: Thu, 28 Apr 2016 13:15:13 -0700 From: Yuanhan Liu To: Thomas Monjalon Cc: dev@dpdk.org Message-ID: <20160428201513.GA5641@yliu-dev.sh.intel.com> References: <1461332640-24273-1-git-send-email-thomas.monjalon@6wind.com> <1461332640-24273-4-git-send-email-thomas.monjalon@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1461332640-24273-4-git-send-email-thomas.monjalon@6wind.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH 3/4] examples: remove useless debug flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Apr 2016 20:15:08 -0000 On Fri, Apr 22, 2016 at 03:43:59PM +0200, Thomas Monjalon wrote: > The debug logs must be enabled at compile-time and run-time. > There are also some internal flags in some examples to enable the debug > logs of the applications. They are now enabled in debug configs and > can be disabled thanks to the more generic logtype mechanism: > rte_set_log_type(RTE_LOGTYPE_USER1, 0); > > Removing these #ifdef allows to test these code branches more easily > and avoid dead code pitfalls. > > Signed-off-by: Thomas Monjalon > --- > examples/distributor/main.c | 19 ++---- > examples/ipsec-secgw/esp.c | 14 ++-- > examples/ipsec-secgw/ipsec.c | 6 +- > examples/ipsec-secgw/ipsec.h | 3 - > examples/l3fwd-acl/main.c | 3 + > examples/packet_ordering/main.c | 18 ++--- > examples/tep_termination/main.c | 7 +- > examples/tep_termination/main.h | 8 --- > examples/vhost/main.c | 143 +++++++++++++++++++++------------------- > examples/vhost/main.h | 12 ---- > examples/vhost_xen/main.c | 62 +++++++---------- > examples/vhost_xen/main.h | 11 ---- For the vhost example part, Acked-by: Yuanhan Liu --yliu