From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f193.google.com (mail-qk0-f193.google.com [209.85.220.193]) by dpdk.org (Postfix) with ESMTP id D8C0C39EA for ; Fri, 29 Apr 2016 23:36:44 +0200 (CEST) Received: by mail-qk0-f193.google.com with SMTP id q184so8969530qkf.0 for ; Fri, 29 Apr 2016 14:36:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ZFQAzgha0w9LChrdX/IyAEy44O355zEbSB4c0yXRc4s=; b=A3sZOkuseF6g4EaCkE0k94tcUUHXkg+q8KpuaRiZ+PoJ8Y1vlaZMbDuHT070EjU575 PRjitrbZikgXtyhyT5N7gwfgOMTBLo0p4CcUXpC+AdakONjCCMqd/FVdvpjUEOXWhSCh I6BvVfdqSay+5sEURMmM5tN71aG6AlKnw14Gvbck/xwc6dBfkZaWNWWMojJrVI0Y9eDF WlKSY0BXiBcwgX1pLL25zg7kVvOLaS8Elb99KgOXC1S62sKFcrGFz1PXdsQGRWIaboTX pS4A+mOzVTQvRnsGY2XEKanvp9lszRGiD3p8TQqHixoYEVyVbuLHygjBRbcQWiIU9NPv VpHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ZFQAzgha0w9LChrdX/IyAEy44O355zEbSB4c0yXRc4s=; b=Lct8/CfijvcHmMZ2Tk7XOgbr2ocA49YcObuklVsIpnciq19E9bgZY28Hm7sRv8MEZX JTJprgQUCu+0xN+WWt7/QhhKVDK0a3ZGCwr5bAZ87QnuDAmmo01nRn7CHnzsfJilINRu cTc5mooaogYZG8zUOKMVGlORazHG6SXmbw+3tSLUnXN+m3C7z+gmOtc7AIM9arwMMPCt Iyb76ohRbeu/+gyRi0hz4ZFvIrVZQ/PEhUmByXk6rgH7IIgWYTBPDIcZB3Vm4wHpkRuL 1zHf5gDHsBum2Q8mUC0VkqeDYFLy0P/eJdvbjlu2eheKLW+zET2YtsUACwCaK3S1TL8N hzLQ== X-Gm-Message-State: AOPr4FXDDmMGGR/LwVeHwaacPEul5kKZNrhMpUspiJbeMtKqN6pK2uQl78/AZ7Yc5gsPxw== X-Received: by 10.55.74.141 with SMTP id x135mr22706750qka.20.1461965804437; Fri, 29 Apr 2016 14:36:44 -0700 (PDT) Received: from gmail.com (pool-108-31-208-15.washdc.fios.verizon.net. [108.31.208.15]) by smtp.gmail.com with ESMTPSA id x11sm5061451qgx.24.2016.04.29.14.36.43 (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 29 Apr 2016 14:36:44 -0700 (PDT) Received: by gmail.com (sSMTP sendmail emulation); Fri, 29 Apr 2016 17:36:42 -0400 Date: Fri, 29 Apr 2016 17:36:42 -0400 From: Eric Kinzie To: Declan Doherty Cc: dev@dpdk.org Message-ID: <20160429213641.GA30947@roosta.home> References: <1460654624-2066-1-git-send-email-ehkinzie@gmail.com> <571F4849.5030509@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <571F4849.5030509@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [dpdk-dev] [PATCH] bond: inherit maximum rx packet length X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Apr 2016 21:36:45 -0000 On Tue Apr 26 11:51:53 +0100 2016, Declan Doherty wrote: > On 14/04/16 18:23, Eric Kinzie wrote: > > Instead of a hard-coded maximum receive length, allow the bond interface > > to inherit this limit from the first slave added. This allows > > an application that uses jumbo frames to pass realistic values to > > rte_eth_dev_configure without causing an error. > > > >Signed-off-by: Eric Kinzie > >--- > ... > > > > Hey Eric, just one small thing, I think it probably makes sense to > return the max rx pktlen for all slaves, so as we add each slave > just check if that the slave being value is larger than the current > value. > > @@ -385,6 +389,10 @@ __eth_bond_slave_add_lock_free(uint8_t > bonded_port_id, uint8_t slave_port_id) > internals->tx_offload_capa &= dev_info.tx_offload_capa; > internals->flow_type_rss_offloads &= > dev_info.flow_type_rss_offloads; > > + /* If new slave's max rx packet size is larger than > current value then override */ > + if (dev_info.max_rx_pktlen > internals->max_rx_pktlen) > + internals->max_rx_pktlen = dev_info.max_rx_pktlen; > + > > Declan Declan, I sent an updated patch but now release that I mis-read your comments. Is it a good idea to change the value once it's been set? My patch now refuses to add a slave with a pktlen value that's smaller than that of the first slave. Eric