From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <viktorin@rehivetech.com>
Received: from wes1-so1.wedos.net (wes1-so1.wedos.net [46.28.106.15])
 by dpdk.org (Postfix) with ESMTP id 80FD26C99
 for <dev@dpdk.org>; Mon,  9 May 2016 17:38:08 +0200 (CEST)
Received: from pcviktorin.fit.vutbr.cz (pcviktorin.fit.vutbr.cz
 [147.229.13.147])
 by wes1-so1.wedos.net (Postfix) with ESMTPSA id 3r3RNc1p1SzBg6;
 Mon,  9 May 2016 17:38:08 +0200 (CEST)
Date: Mon, 9 May 2016 17:36:17 +0200
From: Jan Viktorin <viktorin@rehivetech.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>, David
 Marchand <david.marchand@6wind.com>
Message-ID: <20160509173617.1a4a3199@pcviktorin.fit.vutbr.cz>
In-Reply-To: <7154696.NNSjZHJaDi@xps13>
References: <1462531720-26217-1-git-send-email-viktorin@rehivetech.com>
 <1462531720-26217-2-git-send-email-viktorin@rehivetech.com>
 <7154696.NNSjZHJaDi@xps13>
Organization: RehiveTech
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v1 01/10] app/test: introduce resources for
	tests
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 09 May 2016 15:38:08 -0000

On Fri, 06 May 2016 16:01:08 +0200
Thomas Monjalon <thomas.monjalon@6wind.com> wrote:

> 2016-05-06 12:48, Jan Viktorin:
> > --- /dev/null
> > +++ b/app/test/resource.h
> > @@ -0,0 +1,61 @@
> > +/*-
> > + *   BSD LICENSE  
> [...]
> > + */  
> 
> Please include a multi-line comment here to explain what is a resource
> and why it is needed.
> 
> > +
> > +#ifndef _RESOURCE_H_
> > +#define _RESOURCE_H_
> > +  
> |...]
> |> +
> > +TAILQ_HEAD(resource_list, resource);
> > +extern struct resource_list resource_list;  
> 
> Why extern?

It is not a definition. There is a single global resource_list and
it is defined in the resource.c. A common practice in DPDK (eg. rte_pci.h).
Do I miss something?

Regards
Jan

> 

[...]


-- 
   Jan Viktorin                  E-mail: Viktorin@RehiveTech.com
   System Architect              Web:    www.RehiveTech.com
   RehiveTech
   Brno, Czech Republic