DPDK patches and discussions
 help / color / mirror / Atom feed
From: Santosh Shukla <santosh.shukla@caviumnetworks.com>
To: Hemant Agrawal <hemant.agrawal@nxp.com>
Cc: <dev@dpdk.org>, <jerin.jacob@caviumnetworks.com>,
	<jianbo.liu@linaro.org>,  <thomas.monjalon@6wind.com>
Subject: Re: [dpdk-dev] [PATCHv2 1/2] mk:disabling CONFIG_RTE_EAL_IGB_UIO for armv8a
Date: Tue, 10 May 2016 12:10:14 +0530	[thread overview]
Message-ID: <20160510064012.GB8073@santosh-Latitude-E5530-non-vPro> (raw)
In-Reply-To: <1462881334-21247-1-git-send-email-hemant.agrawal@nxp.com>

On Tue, May 10, 2016 at 05:25:33PM +0530, Hemant Agrawal wrote:
> The compilation with upstream kernel is broken with this config as enabled.
>
few nits:
- 'mk:..' subject header looks incorrect, you can start with 
  config/armv8a: disable igb_uio

- Also pl. reword the description- perhaps IGB_UIO not supported for arm64
 arch so disable.

if you agress to do then patch looks okay to me, 
Reviewed-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>

> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> ---
>  config/defconfig_arm64-armv8a-linuxapp-gcc | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/config/defconfig_arm64-armv8a-linuxapp-gcc b/config/defconfig_arm64-armv8a-linuxapp-gcc
> index 9abeca4..a786562 100644
> --- a/config/defconfig_arm64-armv8a-linuxapp-gcc
> +++ b/config/defconfig_arm64-armv8a-linuxapp-gcc
> @@ -42,6 +42,8 @@ CONFIG_RTE_FORCE_INTRINSICS=y
>  CONFIG_RTE_TOOLCHAIN="gcc"
>  CONFIG_RTE_TOOLCHAIN_GCC=y
>  
> +CONFIG_RTE_EAL_IGB_UIO=n
> +
>  CONFIG_RTE_IXGBE_INC_VECTOR=n
>  CONFIG_RTE_LIBRTE_IVSHMEM=n
>  CONFIG_RTE_LIBRTE_FM10K_PMD=n
> -- 
> 1.9.1
> 

  reply	other threads:[~2016-05-10  6:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-10 11:55 Hemant Agrawal
2016-05-10  6:40 ` Santosh Shukla [this message]
2016-05-10 11:55 ` [dpdk-dev] [PATCHv2 2/2] mk: Introduce NXP dpaa2 architecture based on armv8-a Hemant Agrawal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160510064012.GB8073@santosh-Latitude-E5530-non-vPro \
    --to=santosh.shukla@caviumnetworks.com \
    --cc=dev@dpdk.org \
    --cc=hemant.agrawal@nxp.com \
    --cc=jerin.jacob@caviumnetworks.com \
    --cc=jianbo.liu@linaro.org \
    --cc=thomas.monjalon@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).