From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id D1D4BB3E4 for ; Tue, 10 May 2016 20:22:29 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP; 10 May 2016 11:22:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,605,1455004800"; d="scan'208";a="963019991" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by fmsmga001.fm.intel.com with ESMTP; 10 May 2016 11:22:28 -0700 Date: Tue, 10 May 2016 11:27:13 -0700 From: Yuanhan Liu To: Daniel Mrzyglod Cc: huawei.xie@intel.com, przemyslaw.czesnowicz@intel.com, dev@dpdk.org Message-ID: <20160510182713.GU5641@yliu-dev.sh.intel.com> References: <1462896678-40929-1-git-send-email-danielx.t.mrzyglod@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1462896678-40929-1-git-send-email-danielx.t.mrzyglod@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH] vhost: fix buffer not null terminated X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 May 2016 18:22:30 -0000 On Tue, May 10, 2016 at 06:11:18PM +0200, Daniel Mrzyglod wrote: > Fix issue reported by Coverity. > Coverity ID 124556 > > If the buffer is treated as a null terminated string in later operations, > a buffer overflow or over-read may occur. > > In vhost_set_ifname: The string buffer may not have a null terminator if > the source string's length is equal to the buffer size > > Fixes: 54292e9520e0 ("vhost: support ifname for vhost-user") > > Signed-off-by: Daniel Mrzyglod Applied to dpdk-next-virtio. Thanks. --yliu