From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <viktorin@rehivetech.com>
Received: from wes1-so1.wedos.net (wes1-so1.wedos.net [46.28.106.15])
 by dpdk.org (Postfix) with ESMTP id D3BAE6CB9
 for <dev@dpdk.org>; Thu, 12 May 2016 17:03:28 +0200 (CEST)
Received: from pcviktorin.fit.vutbr.cz (pcviktorin.fit.vutbr.cz
 [147.229.13.147])
 by wes1-so1.wedos.net (Postfix) with ESMTPSA id 3r5GTD4RzczYj;
 Thu, 12 May 2016 17:03:28 +0200 (CEST)
Date: Thu, 12 May 2016 17:01:40 +0200
From: Jan Viktorin <viktorin@rehivetech.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>, David
 Marchand <david.marchand@6wind.com>
Message-ID: <20160512170140.0ca5e5f2@pcviktorin.fit.vutbr.cz>
In-Reply-To: <1678450.4x7Skatt1Y@xps13>
References: <1462531720-26217-1-git-send-email-viktorin@rehivetech.com>
 <7154696.NNSjZHJaDi@xps13>
 <20160506182042.411cf755@pcviktorin.fit.vutbr.cz>
 <1678450.4x7Skatt1Y@xps13>
Organization: RehiveTech
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v1 01/10] app/test: introduce resources for
	tests
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 12 May 2016 15:03:29 -0000

On Thu, 12 May 2016 16:58:31 +0200
Thomas Monjalon <thomas.monjalon@6wind.com> wrote:

> 2016-05-06 18:20, Jan Viktorin:
> > On Fri, 06 May 2016 16:01:08 +0200
> > Thomas Monjalon <thomas.monjalon@6wind.com> wrote:  
> > > 2016-05-06 12:48, Jan Viktorin:  
> > > > +static struct resource linkres_ ##_n = {       \
> > > > +	.name = RTE_STR(_n),     \
> > > > +	.beg = _b,               \
> > > > +	.end = _e,               \
> > > > +};                               \
> > > > +__REGISTER_RESOURCE(linkres_ ##_n)    
> > > 
> > > Please avoid nested macros.  
> > 
> > I don't understand this. I am avoiding code duplication. Is it wrong?  
> 
> Which code duplication?
> Is __REGISTER_RESOURCE used elsewhere?

No :). I've already posted a fix of this.

-- 
   Jan Viktorin                  E-mail: Viktorin@RehiveTech.com
   System Architect              Web:    www.RehiveTech.com
   RehiveTech
   Brno, Czech Republic