From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wes1-so2.wedos.net (wes1-so2.wedos.net [46.28.106.16]) by dpdk.org (Postfix) with ESMTP id BAD359A9D for ; Fri, 13 May 2016 17:21:30 +0200 (CEST) Received: from pcviktorin.fit.vutbr.cz (pcviktorin.fit.vutbr.cz [147.229.13.147]) by wes1-so2.wedos.net (Postfix) with ESMTPSA id 3r5tqZ39L9z4l3; Fri, 13 May 2016 17:21:30 +0200 (CEST) Date: Fri, 13 May 2016 17:19:42 +0200 From: Jan Viktorin To: Thomas Monjalon Cc: dev@dpdk.org, David Marchand , Bruce Richardson Message-ID: <20160513171942.231577b4@pcviktorin.fit.vutbr.cz> In-Reply-To: <1590761.7jRYD2v3H6@xps13> References: <1462904011-29838-1-git-send-email-viktorin@rehivetech.com> <1462904011-29838-9-git-send-email-viktorin@rehivetech.com> <1590761.7jRYD2v3H6@xps13> Organization: RehiveTech MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 08/11] app/test: convert current pci_test into a single test case X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 May 2016 15:21:30 -0000 On Thu, 12 May 2016 17:34:13 +0200 Thomas Monjalon wrote: > 2016-05-10 20:13, Jan Viktorin: > > The current test_pci is just a single test case that tests the blacklisting > > of devices. Rename it to test_pci_blacklist and call it from the test_pci. > > The functions are also moved. It is confusing. > Maybe this patch can be squashed with the previous one. > Well, I wanted to separate the functional changes from cosmetic ones. The goal here is to extract the setup and cleanup phases from the orignal test. Would be better to just change the description? --- app/test: extract setup and cleanup phase from pci_test The original test_pci contains the setup and cleanup phase in its body. By extracting this code out, we can take advantage of this code for other (future) tests as well. The test_pci is renamed to test_pci_blacklist - it's only a single test case (others will follow) now. --- Probably, it can be splitted (instead of squashed with a previous one) to "extract setup and cleanup" and "rename to test_pci_blacklist". Jan -- Jan Viktorin E-mail: Viktorin@RehiveTech.com System Architect Web: www.RehiveTech.com RehiveTech Brno, Czech Republic