From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id A71E069FA for ; Tue, 17 May 2016 12:58:54 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP; 17 May 2016 03:58:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,324,1459839600"; d="scan'208";a="956253872" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.220.113]) by orsmga001.jf.intel.com with SMTP; 17 May 2016 03:58:51 -0700 Received: by (sSMTP sendmail emulation); Tue, 17 May 2016 11:58:50 +0025 Date: Tue, 17 May 2016 11:58:50 +0100 From: Bruce Richardson To: Hiroyuki Mikita Cc: olivier.matz@6wind.com, dev@dpdk.org Message-ID: <20160517105850.GA10652@bricha3-MOBL3> References: <1463327436-6863-1-git-send-email-h.mikita89@gmail.com> <1463417600-20943-1-git-send-email-h.mikita89@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1463417600-20943-1-git-send-email-h.mikita89@gmail.com> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v2] mbuf: decrease refcnt when detaching X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 May 2016 10:58:55 -0000 On Tue, May 17, 2016 at 01:53:20AM +0900, Hiroyuki Mikita wrote: > The rte_pktmbuf_detach() function should decrease refcnt on a direct > buffer. > > Signed-off-by: Hiroyuki Mikita > --- > v2: > * introduced a new function rte_pktmbuf_detach2() which decrease refcnt. > * marked rte_pktmbuf_detach() as deprecated. > * added comments about refcnt to rte_pktmbuf_attach() and rte_pktmbuf_detach(). > * checked refcnt when detaching in unit tests. > * added this issue to release notes. > Rather than detach2, would unattach be better? /Bruce