From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wes1-so1.wedos.net (wes1-so1.wedos.net [46.28.106.15]) by dpdk.org (Postfix) with ESMTP id 9FDD091BF for ; Thu, 19 May 2016 10:52:53 +0200 (CEST) Received: from pcviktorin.fit.vutbr.cz (pcviktorin.fit.vutbr.cz [147.229.13.147]) by wes1-so1.wedos.net (Postfix) with ESMTPSA id 3r9PwP34plz4JY; Thu, 19 May 2016 10:52:53 +0200 (CEST) Date: Thu, 19 May 2016 10:51:10 +0200 From: Jan Viktorin To: dev@dpdk.org Cc: Thomas Monjalon , David Marchand , Bruce Richardson Message-ID: <20160519105110.4125797b@pcviktorin.fit.vutbr.cz> In-Reply-To: <1463510101-5633-10-git-send-email-viktorin@rehivetech.com> References: <1463510101-5633-1-git-send-email-viktorin@rehivetech.com> <1463510101-5633-10-git-send-email-viktorin@rehivetech.com> Organization: RehiveTech MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 09/11] eal/pci: allow to override sysfs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 May 2016 08:52:53 -0000 I forgot to fix those: 12826: ERROR: code indent should use tabs where possible #175: FILE: lib/librte_eal/linuxapp/eal/eal_pci.c:69: +^I "%s/" PCI_PRI_FMT "/driver/unbind", pci_get_sysfs_path(),$ WARNING: line over 80 characters #193: FILE: lib/librte_eal/linuxapp/eal/eal_pci.c:471: +snprintf(dirname, sizeof(dirname), "%s/%s", pci_get_sysfs_path(), total: 1 errors, 1 warnings, 160 lines checked NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or scripts/cleanfile will do for v4. Jan On Tue, 17 May 2016 20:34:59 +0200 Jan Viktorin wrote: > The SYSFS_PCI_DEVICES is a constant that makes the PCI testing difficult as > it points to an absolute path. We remove using this constant and introducing > a function pci_get_sysfs_path that gives the same value. However, the user can > pass a SYSFS_PCI_DEVICES env variable to override the path. It is now possible > to create a fake sysfs hierarchy for testing. > > Signed-off-by: Jan Viktorin > --- > v3: > * changed subject > * test_pci_sysfs has been slightly modified to be more understandable > * fixed whitespace in *version.map files > --- > app/test/test_pci.c | 28 +++++++++++++++++++++++++ > drivers/net/szedata2/rte_eth_szedata2.c | 2 +- > drivers/net/virtio/virtio_pci.c | 2 +- > lib/librte_eal/bsdapp/eal/rte_eal_version.map | 7 +++++++ > lib/librte_eal/common/eal_common_pci.c | 13 ++++++++++++ > lib/librte_eal/common/include/rte_pci.h | 2 +- > lib/librte_eal/linuxapp/eal/eal_pci.c | 6 +++--- > lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 7 ++++--- > lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 2 +- > lib/librte_eal/linuxapp/eal/rte_eal_version.map | 7 +++++++ > 10 files changed, 66 insertions(+), 10 deletions(-) > [...]