From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 7398E5961 for ; Mon, 23 May 2016 15:51:32 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP; 23 May 2016 06:51:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,356,1459839600"; d="scan'208";a="812890721" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by orsmga003.jf.intel.com with ESMTP; 23 May 2016 06:51:30 -0700 Date: Mon, 23 May 2016 21:52:53 +0800 From: Yuanhan Liu To: Olivier Matz Cc: dev@dpdk.org, huawei.xie@intel.com, stephen@networkplumber.org Message-ID: <20160523135253.GN5641@yliu-dev.sh.intel.com> References: <1462810775-7538-1-git-send-email-olivier.matz@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1462810775-7538-1-git-send-email-olivier.matz@6wind.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH] virtio: check mbuf is direct when using any layout X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 May 2016 13:51:32 -0000 On Mon, May 09, 2016 at 06:19:35PM +0200, Olivier Matz wrote: > The commit dd856dfcb9e74 introduced an optimization that prepends virtio > header to mbuf data. It can be used when the tx mbuf is writeable, so we > need to check that the mbuf is direct (i.e. it embeds its own data). > > Fixes: dd856dfcb9e74 "virtio: use any layout on Tx" Missing "()" here. Fixed and applied to dpdk-next-virtio. Thanks. --yliu