From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 458FE5A51 for ; Tue, 24 May 2016 07:14:26 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP; 23 May 2016 22:14:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,359,1459839600"; d="scan'208";a="987372759" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by fmsmga002.fm.intel.com with ESMTP; 23 May 2016 22:14:23 -0700 Date: Tue, 24 May 2016 13:15:52 +0800 From: Yuanhan Liu To: Olivier Matz Cc: David Marchand , "dev@dpdk.org" , Chao Zhu , "Xie, Huawei" , Panu Matilainen , Thomas Monjalon Message-ID: <20160524051552.GQ5641@yliu-dev.sh.intel.com> References: <1463143859-3105-1-git-send-email-olivier.matz@6wind.com> <1463479192-2488-1-git-send-email-olivier.matz@6wind.com> <1463479192-2488-6-git-send-email-olivier.matz@6wind.com> <20160523130749.GJ5641@yliu-dev.sh.intel.com> <5743086A.2020103@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5743086A.2020103@6wind.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v2 5/7] eal/linux: mmap ioports on ppc64 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 May 2016 05:14:26 -0000 On Mon, May 23, 2016 at 03:40:58PM +0200, Olivier Matz wrote: > For reference, here is the report of the ABI checker for EAL: > > [−] struct rte_pci_ioport (2) > > 1 Field len has been added to this type. > 1) This field will not be initialized by old clients. > 2) Size of the inclusive type has been changed. > NOTE: this field should be accessed only from the new library > functions, otherwise it may result in crash or incorrect behavior > of applications. > 2 Size of this type has been changed from 16 bytes to 24 bytes. > The fields or parameters of such data type may be incorrectly > initialized or accessed by old client applications. > > [−] affected symbols (4) > rte_eal_pci_ioport_map ( struct rte_pci_device* dev, int bar, > struct rte_pci_ioport* p ) @@ DPDK_16.04 > 3rd parameter 'p' (pointer) has base type 'struct rte_pci_ioport'. > rte_eal_pci_ioport_read ( struct rte_pci_ioport* p, void* data, > size_t len, off_t offset ) @@ DPDK_16.04 > 1st parameter 'p' (pointer) has base type 'struct rte_pci_ioport'. > rte_eal_pci_ioport_unmap ( struct rte_pci_ioport* p ) @@ DPDK_16.04 > 1st parameter 'p' (pointer) has base type 'struct rte_pci_ioport'. > rte_eal_pci_ioport_write ( struct rte_pci_ioport* p, void const* data, > size_t len, off_t offset ) @@ DPDK_16.04 > 1st parameter 'p' (pointer) has base type 'struct rte_pci_ioport'. > > > My understanding of the comment for this structure is that it's > internal to EAL: I'm not quite sure that is enough. Cc'ed Panu, the guru on ABI stuff, hopefully he could shed some light on it. > /** > * A structure used to access io resources for a pci device. > * rte_pci_ioport is arch, os, driver specific, and should not be used > outside > * of pci ioport api. > */ > struct rte_pci_ioport { > ... > } > > So I'd say it's ok to have it integrated for 16.07. I'll let Thomas to decide it :) --yliu