From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by dpdk.org (Postfix) with ESMTP id 1AAEB5A6C for ; Tue, 24 May 2016 08:27:30 +0200 (CEST) Received: from pps.filterd (m0048827.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u4O6PKpL008175 for ; Tue, 24 May 2016 02:27:30 -0400 Message-Id: <201605240627.u4O6PKpL008175@mx0a-001b2d01.pphosted.com> Received: from e28smtp05.in.ibm.com (e28smtp05.in.ibm.com [125.16.236.5]) by mx0a-001b2d01.pphosted.com with ESMTP id 234dxx3gmh-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 24 May 2016 02:27:29 -0400 Received: from localhost by e28smtp05.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 24 May 2016 11:57:26 +0530 Received: from d28dlp03.in.ibm.com (9.184.220.128) by e28smtp05.in.ibm.com (192.168.1.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 24 May 2016 11:57:25 +0530 X-IBM-Helo: d28dlp03.in.ibm.com X-IBM-MailFrom: chaozhu@linux.vnet.ibm.com X-IBM-RcptTo: dev@dpdk.org Received: from d28relay08.in.ibm.com (d28relay08.in.ibm.com [9.184.220.159]) by d28dlp03.in.ibm.com (Postfix) with ESMTP id 2A58D125806E for ; Tue, 24 May 2016 11:59:39 +0530 (IST) Received: from d28av02.in.ibm.com (d28av02.in.ibm.com [9.184.220.64]) by d28relay08.in.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u4O6RLWU38862912 for ; Tue, 24 May 2016 11:57:22 +0530 Received: from d28av02.in.ibm.com (localhost [127.0.0.1]) by d28av02.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u4O6RJI6005470 for ; Tue, 24 May 2016 11:57:20 +0530 Received: from ADMINIB2M8Q79C ([9.186.50.177]) by d28av02.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id u4O6RGfd003889; Tue, 24 May 2016 11:57:17 +0530 From: "Chao Zhu" To: "'Olivier Matz'" , Cc: , , References: <1463143859-3105-1-git-send-email-olivier.matz@6wind.com> <1463479192-2488-1-git-send-email-olivier.matz@6wind.com> <1463479192-2488-7-git-send-email-olivier.matz@6wind.com> <000301d1b1ae$cebf1470$6c3d3d50$@linux.vnet.ibm.com> <573EFEEF.4040800@6wind.com> In-Reply-To: <573EFEEF.4040800@6wind.com> Date: Tue, 24 May 2016 14:28:18 +0800 MIME-Version: 1.0 Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 15.0 Thread-Index: AQFvWQjkTuva4JuuLgj8jHfVWgXtHAE87zmKArbVcbUCdu+RSgHwq7kGoEl8cZA= Content-Language: zh-cn X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16052406-0016-0000-0000-0000028AD5BC X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16052406-0017-0000-0000-000023E6B329 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2016-05-24_02:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=8 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1605240074 Subject: Re: [dpdk-dev] [PATCH v2 6/7] virtio: fix pci accesses for ppc64 in legacy mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 May 2016 06:27:31 -0000 Olivier, The patch set looks good. I think little endian is good enough. We internally decide to only support little endian previously. You can keep = the endian conversion such kind of things in the code. -----Original Message----- From: Olivier Matz [mailto:olivier.matz@6wind.com]=20 Sent: 2016=C4=EA5=D4=C220=C8=D5 20:11 To: Chao Zhu ; dev@dpdk.org Cc: david.marchand@6wind.com; yuanhan.liu@linux.intel.com; = huawei.xie@intel. com Subject: Re: [PATCH v2 6/7] virtio: fix pci accesses for ppc64 in legacy mode Hi Chao, On 05/19/2016 11:13 AM, Chao Zhu wrote: > Olivier, >=20 > Thanks for the patches!=20 > Just one comment: > POWER8 machine only supports little endian OS on bare metal. In VM=20 > guest, it can support both little endian and big endian OS. Did you=20 > try to run it on both host (little endian) and guest (big endian and little endian)? No I didn't test big endian in the guest. I don't have any big endian VM image. Is it required for the test? I = mean, is it possible to run a big endian DPDK userland application on a little endian kernel? (and if yes, is it known to work?) Maybe I could replace in the patch: #ifdef RTE_ARCH_PPC_64 By something like : #if defined(RTE_ARCH_PPC_64) && (RTE_BYTE_ORDER =3D=3D = RTE_LITTLE_ENDIAN) If you have the ability to test it easily, it would be appreciated :) Thanks for the review! Olivier