From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id BB417567F for ; Wed, 25 May 2016 06:40:22 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP; 24 May 2016 21:40:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,363,1459839600"; d="scan'208";a="973979621" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by fmsmga001.fm.intel.com with ESMTP; 24 May 2016 21:40:20 -0700 Date: Wed, 25 May 2016 12:41:59 +0800 From: Yuanhan Liu To: Bruce Richardson Cc: Ferruh Yigit , Thomas Monjalon , dev@dpdk.org, Tetsuya Mukawa Message-ID: <20160525044159.GS5641@yliu-dev.sh.intel.com> References: <20160509213124.GK5641@yliu-dev.sh.intel.com> <38538365.t1P5Ut1YhZ@xps13> <573DE9BE.4070807@intel.com> <1891939.OmQDtN0y3O@xps13> <20160520103746.GA19260@bricha3-MOBL3> <20160523132426.GK5641@yliu-dev.sh.intel.com> <5743388D.5080108@intel.com> <20160524051126.GP5641@yliu-dev.sh.intel.com> <20160524094256.GA3264@bricha3-MOBL3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160524094256.GA3264@bricha3-MOBL3> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v2] vhost: add support for dynamic vhost PMD creation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 May 2016 04:40:23 -0000 On Tue, May 24, 2016 at 10:42:56AM +0100, Bruce Richardson wrote: > On Tue, May 24, 2016 at 01:11:26PM +0800, Yuanhan Liu wrote: > > On Mon, May 23, 2016 at 06:06:21PM +0100, Ferruh Yigit wrote: > > > On 5/23/2016 2:24 PM, Yuanhan Liu wrote: > > > > On Fri, May 20, 2016 at 11:37:47AM +0100, Bruce Richardson wrote: > > > >> On Thu, May 19, 2016 at 06:44:44PM +0200, Thomas Monjalon wrote: > > > >>> 2016-05-19 17:28, Ferruh Yigit: > > > >>>> On 5/19/2016 9:33 AM, Thomas Monjalon wrote: > > > >>>>> 2016-05-18 18:10, Ferruh Yigit: > > > >>>>>> Add rte_eth_from_vhost() API to create vhost PMD dynamically from > > > >>>>>> applications. > > > >>>>> > > > >>>>> How is it different from rte_eth_dev_attach() calling rte_eal_vdev_init()? > > > >>>>> > > > >>>> > > > >>>> When used rte_eth_dev_attach(), application also needs to do: > > > >>>> rte_eth_dev_configure() > > > >>>> rte_eth_rx_queue_setup() > > > >>>> rte_eth_tx_queue_setup() > > > >>>> rte_eth_dev_start() > > > >>>> > > > >>>> rte_eth_from_vhost() does these internally, easier to use for applications. > > > >>> > > > >>> This argument is not sufficient. > > > >>> We are not going to add new APIs just for wrapping others. > > > >> > > > >> Why not - if there is a sufficient increase in developer usability by doing so? > > > >> Having one API that saves an app from having to call 5 other APIs looks like > > > >> something that should always be given fair consideration. > > > > > > > > Good point. Judging that vhost is not the only virtual device we > > > > support, and it may also look reasonable to add something similar > > > > for others in future (say, IIRC, you proposed two more internally > > > > that also introduced similar APIs). So, instead of introducing a > > > > new API for each such vdev, may we introduce a common one? Say, > > > > a refined rte_eth_dev_attach(), including dev_configure(), > > > > queue_setup(), etc. > > > > > > > > > > This sounds good to me. If there is not objection, I will send a patch > > > and we can discuss based on patch. > > > > Let's wait and gather some comments first? > > > I'm not sure that such a general approach is likely to work, Me, neither. Thus I threw it out for more discussion. > as the parameters > needed for each individual driver are going to be different. Well, if you plan to pass all necessary informations to the driver by parameters like this v1 does, then yes, that's true and a generic API is unlikely to work. But what I was thinking is that we feed it by strings, like the arguments for '--vdev' option. In such way, we could have an unified interface (if that works, which is something I'm not quite sure). OTOH, let's assume there is a switch that supports quite many such vdevs, as well as the ability to add a new device dynamically by corresponding API. And assume there is just one external interface from the switch to add a dynamical device (say, "ovs-vsctl add-port"), you then also need build some codes to invoke the right API, as well as constructing the right parameters, like what you said below. This let me think of the vhost dequeue/enqueue API. Basically speaking, it has the same functionality the rte_eth_rx/tx_burst has, but just different API name and different parameters. This results to OVS has to write different netdev_class, one for NIC, another one for vhost-user. (actually, there is yet another one for vhost-cuse). And now since we have vhost-pmd, we could just have one netdev_class at OVS, saving their (and other application's) effort to build/maintain similar codes. Thus, I'm __just wondering__ could we add a generic interface to create vdev dynamically for all such vdevs? I was thinking something like: rte_create_vdev(type, char *options); Which in turn will invoke the right function pointer for different "type" to do the right setups. --yliu > For some devices, > much of the parameters can be implied, while for others they may not be and still > others needed additional setup parameters. For the simplest case, take the > rte_eth_from_ring API, which creates an ethdev backed by a single rte_ring. The > number of rx and tx queues and their sizes are all determined by the actual > underlying ring, as is the numa node and all other parameters. On the other > hand, we have something like a pcap PMD, where again none of the queue sizes > need to be specified, but we do need additional parameters to provide the > underlying pcap file/device to use. Other devices will similarly need different > options, including in some cases queue counts and sizes. > > Therefore, I think trying to generalise the function is pointless. If you have > to write your code to build up a specific set of parameters to pass to a general > API, then you are no better off than just calling a specific API directly. In > both cases you need different code for each device type. > > Regards, > /Bruce