From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 8BAA8374F
 for <dev@dpdk.org>; Wed, 25 May 2016 17:02:41 +0200 (CEST)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by orsmga101.jf.intel.com with ESMTP; 25 May 2016 08:02:21 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,364,1459839600"; d="scan'208";a="814607067"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.220.175])
 by orsmga003.jf.intel.com with SMTP; 25 May 2016 08:02:20 -0700
Received: by  (sSMTP sendmail emulation); Wed, 25 May 2016 16:02:18 +0025
Date: Wed, 25 May 2016 16:02:17 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: Stephen Hurd <stephen.hurd@broadcom.com>
Cc: dev@dpdk.org
Message-ID: <20160525150216.GA12776@bricha3-MOBL3>
References: <CAJ9nmBYsstDhTCB4H1V5zGFD7ffTeXd=L+v+pdCjqB5KJ6AEvQ@mail.gmail.com>
 <1463179589-82681-1-git-send-email-stephen.hurd@broadcom.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1463179589-82681-1-git-send-email-stephen.hurd@broadcom.com>
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] [PATCH v2 01/40] bnxt: new driver for Broadcom
 NetXtreme-C devices
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 25 May 2016 15:02:42 -0000

On Fri, May 13, 2016 at 03:45:50PM -0700, Stephen Hurd wrote:
> Initial skeleton simply fails init.
> Add nic guide and tie into build system.
> 
> Signed-off-by: Stephen Hurd <stephen.hurd@broadcom.com>
> ---
>  MAINTAINERS                                     |   5 ++
>  config/common_base                              |   5 ++
>  doc/guides/nics/bnxt.rst                        |  49 +++++++++++
>  drivers/net/Makefile                            |   1 +
>  drivers/net/bnxt/Makefile                       |  63 ++++++++++++++
>  drivers/net/bnxt/bnxt_ethdev.c                  | 104 ++++++++++++++++++++++++
>  drivers/net/bnxt/rte_pmd_bnxt_version.map       |   4 +
>  lib/librte_eal/common/include/rte_pci_dev_ids.h |  40 +++++++--
>  mk/rte.app.mk                                   |   1 +
>  9 files changed, 267 insertions(+), 5 deletions(-)
>  create mode 100644 doc/guides/nics/bnxt.rst
>  create mode 100644 drivers/net/bnxt/Makefile
>  create mode 100644 drivers/net/bnxt/bnxt_ethdev.c
>  create mode 100644 drivers/net/bnxt/rte_pmd_bnxt_version.map
> 
Great to see this patchset split up finer grained, and it getting compiled from
the start. Thanks for the work.

One error that gets flagged by the automated patch checks here is that, although
you add in a new doc for the new driver in this patch, that document is not
included in the overall NIC guides document.

    /home/bruce/next-net/dpdk-next-net/doc/guides/nics/bnxt.rst:: WARNING: document isn't included in any toctree

Regards,
/Bruce