From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id D8537FFA
 for <dev@dpdk.org>; Wed, 25 May 2016 17:05:21 +0200 (CEST)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by orsmga102.jf.intel.com with ESMTP; 25 May 2016 08:05:19 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,364,1459839600"; d="scan'208";a="814609069"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.220.175])
 by orsmga003.jf.intel.com with SMTP; 25 May 2016 08:05:18 -0700
Received: by  (sSMTP sendmail emulation); Wed, 25 May 2016 16:05:16 +0025
Date: Wed, 25 May 2016 16:05:15 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: Stephen Hurd <stephen.hurd@broadcom.com>
Cc: dev@dpdk.org
Message-ID: <20160525150514.GB12776@bricha3-MOBL3>
References: <CAJ9nmBYsstDhTCB4H1V5zGFD7ffTeXd=L+v+pdCjqB5KJ6AEvQ@mail.gmail.com>
 <1463179589-82681-1-git-send-email-stephen.hurd@broadcom.com>
 <1463179589-82681-2-git-send-email-stephen.hurd@broadcom.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1463179589-82681-2-git-send-email-stephen.hurd@broadcom.com>
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] [PATCH v2 02/40] bnxt: add HWRM init code
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 25 May 2016 15:05:22 -0000

On Fri, May 13, 2016 at 03:45:51PM -0700, Stephen Hurd wrote:
> Start adding HWRM support.
> Initial commit just performs necessary HWRM queries for init, then
> fails as before.
> 
> Thee used HWRM calls so far:
> bnxt_hwrm_func_qcaps:
> 	Queries device capabilities.
> 
> bnxt_hwrm_ver_get:
> 	Gets the firmware version and interface specifications.
> 	Returns an error if the firmware on the device is not
> 	supported by the driver and ensures the response space
> 	is large enough for the largest possible response.
> 
> bnxt_hwrm_queue_qportcfg:
> 	Required to get the default queue ID.
> 
> Signed-off-by: Stephen Hurd <stephen.hurd@broadcom.com>
> Reviewed-by: David Christensen <david.christensen@broadcom.com>

Can you please clarify in the commit message what HWRM acronym stands for.

Checkpatch also highlights a few minor issues that might be worth addressing.

  CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
  #137: FILE: drivers/net/bnxt/bnxt.h:94:
  +#define BNXT_FLAG_VF           (1<<1)
                                  ^

  WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
  #259: FILE: drivers/net/bnxt/bnxt_ethdev.c:143:
  +       /*
  +       eth_dev->rx_pkt_burst = &bnxt_recv_pkts;

  WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
  #366: FILE: drivers/net/bnxt/bnxt_hwrm.c:56:
  +       unsigned i;

Regards,
/Bruce