From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 5F8C73777 for ; Wed, 25 May 2016 18:37:13 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP; 25 May 2016 09:37:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,364,1459839600"; d="scan'208";a="110377515" Received: from kjtomczy-mobl.ger.corp.intel.com ([10.252.31.37]) by fmsmga004.fm.intel.com with SMTP; 25 May 2016 09:37:10 -0700 Received: by (sSMTP sendmail emulation); Wed, 25 May 2016 17:37:09 +0025 Date: Wed, 25 May 2016 17:37:09 +0100 From: Bruce Richardson To: Stephen Hurd Cc: dev@dpdk.org Message-ID: <20160525163709.GB10676@bricha3-MOBL3> References: <1463179589-82681-1-git-send-email-stephen.hurd@broadcom.com> <1463179589-82681-7-git-send-email-stephen.hurd@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1463179589-82681-7-git-send-email-stephen.hurd@broadcom.com> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v2 07/40] bnxt: declare ring structs and free() func X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 May 2016 16:37:13 -0000 On Fri, May 13, 2016 at 03:45:56PM -0700, Stephen Hurd wrote: > Declare ring structures and a ring free() function. > Are these rings used for packet RX and TX or something else? > Signed-off-by: Stephen Hurd > Reviewed-by: Ajit Kumar Khaparde > --- > drivers/net/bnxt/Makefile | 1 + > drivers/net/bnxt/bnxt_ring.c | 51 ++++++++++++++++++++++++ > drivers/net/bnxt/bnxt_ring.h | 92 ++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 144 insertions(+) > create mode 100644 drivers/net/bnxt/bnxt_ring.c > create mode 100644 drivers/net/bnxt/bnxt_ring.h > > diff --git a/drivers/net/bnxt/Makefile b/drivers/net/bnxt/Makefile > index c57afaa..757ea62 100644 > --- a/drivers/net/bnxt/Makefile > +++ b/drivers/net/bnxt/Makefile > @@ -50,6 +50,7 @@ EXPORT_MAP := rte_pmd_bnxt_version.map > # > SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += bnxt_ethdev.c > SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += bnxt_hwrm.c > +SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += bnxt_ring.c > SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += bnxt_vnic.c > > # > diff --git a/drivers/net/bnxt/bnxt_ring.c b/drivers/net/bnxt/bnxt_ring.c > new file mode 100644 > index 0000000..0434b07 > --- /dev/null > +++ b/drivers/net/bnxt/bnxt_ring.c > @@ -0,0 +1,51 @@ > +/*- > + * BSD LICENSE > + * > + * Copyright(c) Broadcom Limited. > + * All rights reserved. > + * > + * Redistribution and use in source and binary forms, with or without > + * modification, are permitted provided that the following conditions > + * are met: > + * > + * * Redistributions of source code must retain the above copyright > + * notice, this list of conditions and the following disclaimer. > + * * Redistributions in binary form must reproduce the above copyright > + * notice, this list of conditions and the following disclaimer in > + * the documentation and/or other materials provided with the > + * distribution. > + * * Neither the name of Broadcom Corporation nor the names of its > + * contributors may be used to endorse or promote products derived > + * from this software without specific prior written permission. > + * > + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS > + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT > + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR > + * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT > + * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, > + * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT > + * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, > + * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY > + * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT > + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE > + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > + */ > + > +#include "bnxt.h" > +#include "bnxt_ring.h" > + > +/* > + * Generic ring handling > + */ > + > +void bnxt_free_ring(struct bnxt_ring_struct *ring) > +{ > + /* The actual ring is reserved via rte_memzone_reserve API. > + The current document/code indicates that: > + "Note: A reserved zone cannot be freed." I don't believe this is true any more. With recent changes to base memzones on malloc library, the memzones should be free-able. /Bruce