From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 8B5B82BDF
 for <dev@dpdk.org>; Thu, 26 May 2016 11:01:25 +0200 (CEST)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by fmsmga104.fm.intel.com with ESMTP; 26 May 2016 02:01:24 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,367,1459839600"; d="scan'208";a="974866272"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.220.104])
 by fmsmga001.fm.intel.com with SMTP; 26 May 2016 02:01:23 -0700
Received: by  (sSMTP sendmail emulation); Thu, 26 May 2016 10:01:22 +0025
Date: Thu, 26 May 2016 10:01:21 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: Stephen Hurd <stephen.hurd@broadcom.com>
Cc: dev@dpdk.org, Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>
Message-ID: <20160526090121.GA11928@bricha3-MOBL3>
References: <CAJ9nmBYsstDhTCB4H1V5zGFD7ffTeXd=L+v+pdCjqB5KJ6AEvQ@mail.gmail.com>
 <1463179589-82681-1-git-send-email-stephen.hurd@broadcom.com>
 <1463179589-82681-2-git-send-email-stephen.hurd@broadcom.com>
 <20160525150514.GB12776@bricha3-MOBL3>
 <CAJ9nmBbOSnpLGmvrWprdEVDyUqjF_6inYS8gk-rQcadJJc6L4Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAJ9nmBbOSnpLGmvrWprdEVDyUqjF_6inYS8gk-rQcadJJc6L4Q@mail.gmail.com>
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] [PATCH v2 02/40] bnxt: add HWRM init code
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 26 May 2016 09:01:26 -0000

On Wed, May 25, 2016 at 04:35:27PM -0700, Stephen Hurd wrote:
> On Wed, May 25, 2016 at 8:05 AM, Bruce Richardson <
> bruce.richardson@intel.com> wrote:
> 
> >
> > Checkpatch also highlights a few minor issues that might be worth
> > addressing.
> >
> >   CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
> >   #137: FILE: drivers/net/bnxt/bnxt.h:94:
> >   +#define BNXT_FLAG_VF           (1<<1)
> >                                   ^
> >
> >   WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
> >   #259: FILE: drivers/net/bnxt/bnxt_ethdev.c:143:
> >   +       /*
> >   +       eth_dev->rx_pkt_burst = &bnxt_recv_pkts;
> >
> >   WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
> >   #366: FILE: drivers/net/bnxt/bnxt_hwrm.c:56:
> >   +       unsigned i;
> >
> >
> What version of checkpatch.pl should we be using?  These were not found by
> the one I had.
> 
Not to worry, a few checkpatch issues are not that big a problem, I can fix them
on apply if necessary.

I used the latest checkpatch version on linus' tree, since I just did a clone
of that before starting looking at your set. Since I don't pull down the patches
as patch files, but use pwclient git-am to apply them, I don't use the checkpatches.sh
script. The actual command/script I use is:

#! /bin/sh

IGNORE_FLAGS="LINUX_VERSION_CODE,FILE_PATH_CHANGES,\
VOLATILE,PREFER_PACKED,PREFER_ALIGNED,\
PREFER_PRINTF,PREFER_KERNEL_TYPES,\
PARENTHESIS_ALIGNMENT,NETWORKING_BLOCK_COMMENT_STYLE,\
COMPARISON_TO_NULL,SPLIT_STRING,BIT_MACRO,LINE_SPACING"

git show --pretty=email | /usr/src/linux/scripts/checkpatch.pl --max-line-length=90 --show-types --ignore=$IGNORE_FLAGS -

The ignore flags should be pretty much the same as in checkpatches.pl, but there
may be a couple of differences, since I haven't synced them up in some time. I
will attempt do so in the near future, to avoid confusion here.

/Bruce