From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 34F5F2BDF for ; Thu, 26 May 2016 11:05:47 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP; 26 May 2016 02:05:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,367,1459839600"; d="scan'208";a="974868979" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.220.104]) by fmsmga001.fm.intel.com with SMTP; 26 May 2016 02:05:29 -0700 Received: by (sSMTP sendmail emulation); Thu, 26 May 2016 10:05:28 +0025 Date: Thu, 26 May 2016 10:05:27 +0100 From: Bruce Richardson To: Stephen Hurd Cc: dev@dpdk.org, Ajit Kumar Khaparde Message-ID: <20160526090527.GB11928@bricha3-MOBL3> References: <1463179589-82681-1-git-send-email-stephen.hurd@broadcom.com> <20160525150216.GA12776@bricha3-MOBL3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v2 01/40] bnxt: new driver for Broadcom NetXtreme-C devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 May 2016 09:05:47 -0000 On Wed, May 25, 2016 at 01:59:00PM -0700, Stephen Hurd wrote: > Bruce, is it better at this point to modify the existing patch that adds > bnxt.rst or to create a follow-on patch? > It's better to modify existing patch to add it. However, hold off on doing new versions of the patchset until I've finished doing a first initial scan of them as-is [you'll see from my emails I'm less than half way in at this point! :-)]. I'd also like to see if some others can help out with reviewing this patchset. It is a lot of patches, but since they are logically broken up by functionality, each one is of more manageable size. Any volunteers? /Bruce > On Wed, May 25, 2016 at 8:02 AM, Bruce Richardson < > bruce.richardson@intel.com> wrote: > > > On Fri, May 13, 2016 at 03:45:50PM -0700, Stephen Hurd wrote: > > > Initial skeleton simply fails init. > > > Add nic guide and tie into build system. > > > > > > Signed-off-by: Stephen Hurd > > > --- > > > MAINTAINERS | 5 ++ > > > config/common_base | 5 ++ > > > doc/guides/nics/bnxt.rst | 49 +++++++++++ > > > drivers/net/Makefile | 1 + > > > drivers/net/bnxt/Makefile | 63 ++++++++++++++ > > > drivers/net/bnxt/bnxt_ethdev.c | 104 > > ++++++++++++++++++++++++ > > > drivers/net/bnxt/rte_pmd_bnxt_version.map | 4 + > > > lib/librte_eal/common/include/rte_pci_dev_ids.h | 40 +++++++-- > > > mk/rte.app.mk | 1 + > > > 9 files changed, 267 insertions(+), 5 deletions(-) > > > create mode 100644 doc/guides/nics/bnxt.rst > > > create mode 100644 drivers/net/bnxt/Makefile > > > create mode 100644 drivers/net/bnxt/bnxt_ethdev.c > > > create mode 100644 drivers/net/bnxt/rte_pmd_bnxt_version.map > > > > > Great to see this patchset split up finer grained, and it getting compiled > > from > > the start. Thanks for the work. > > > > One error that gets flagged by the automated patch checks here is that, > > although > > you add in a new doc for the new driver in this patch, that document is not > > included in the overall NIC guides document. > > > > /home/bruce/next-net/dpdk-next-net/doc/guides/nics/bnxt.rst:: WARNING: > > document isn't included in any toctree > > > > Regards, > > /Bruce > > > > > > > -- > Stephen Hurd > Principal Engineer - Software Development > Broadcom Corporation > 949-926-8039 > stephen.hurd@broadcom.com