From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 6FF202E8E
 for <dev@dpdk.org>; Thu, 26 May 2016 12:52:31 +0200 (CEST)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by orsmga102.jf.intel.com with ESMTP; 26 May 2016 03:52:32 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,367,1459839600"; d="scan'208";a="974921576"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.220.104])
 by fmsmga001.fm.intel.com with SMTP; 26 May 2016 03:52:01 -0700
Received: by  (sSMTP sendmail emulation); Thu, 26 May 2016 11:52:00 +0025
Date: Thu, 26 May 2016 11:52:00 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: Stephen Hurd <stephen.hurd@broadcom.com>
Cc: dev@dpdk.org
Message-ID: <20160526105200.GF11928@bricha3-MOBL3>
References: <CAJ9nmBYsstDhTCB4H1V5zGFD7ffTeXd=L+v+pdCjqB5KJ6AEvQ@mail.gmail.com>
 <1463179589-82681-1-git-send-email-stephen.hurd@broadcom.com>
 <1463179589-82681-14-git-send-email-stephen.hurd@broadcom.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1463179589-82681-14-git-send-email-stephen.hurd@broadcom.com>
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] [PATCH v2 14/40] bnxt: initial Rx ring code
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 26 May 2016 10:52:31 -0000

On Fri, May 13, 2016 at 03:46:03PM -0700, Stephen Hurd wrote:
> Initial implementation of rx_pkt_burst
> Add code to allocate rings to bnxt_ring.c
> 
> Signed-off-by: Stephen Hurd <stephen.hurd@broadcom.com>
> Reviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>
> ---
>  drivers/net/bnxt/Makefile              |   1 +
>  drivers/net/bnxt/bnxt_ethdev.c         |   3 +-
>  drivers/net/bnxt/bnxt_ring.c           |  20 +-
>  drivers/net/bnxt/bnxt_rxq.c            |  34 ++-
>  drivers/net/bnxt/bnxt_rxr.c            | 338 +++++++++++++++++++++++
>  drivers/net/bnxt/bnxt_rxr.h            |  62 +++++
>  drivers/net/bnxt/hsi_struct_def_dpdk.h | 474 +++++++++++++++++++++++++++++++++
>  7 files changed, 915 insertions(+), 17 deletions(-)
>  create mode 100644 drivers/net/bnxt/bnxt_rxr.c
>  create mode 100644 drivers/net/bnxt/bnxt_rxr.h
> 
<snip>
> + */
> +
> +static inline struct rte_mbuf *__bnxt_alloc_rx_data(struct rte_mempool *mb)
> +{
> +	struct rte_mbuf *data;
> +
> +	data = __rte_mbuf_raw_alloc(mb);

This function is now deprecated and the version without "__" prefix should
now be used instead. "rte_mbuf_raw_alloc()"

> +	__rte_mbuf_sanity_check(data, 0);

raw_mbuf_raw_alloc already includes a call to sanity_check, so this can be removed.
Perhaps the whole function __bnxt_alloc_rx_data() can be removed as it just
seems to be duplicating rte_mbuf_raw_alloc().

Regards,
/Bruce