From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id A6C77377C
 for <dev@dpdk.org>; Thu, 26 May 2016 14:45:59 +0200 (CEST)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by fmsmga102.fm.intel.com with ESMTP; 26 May 2016 05:45:59 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,367,1459839600"; d="scan'208";a="709250807"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.252.31.37])
 by FMSMGA003.fm.intel.com with SMTP; 26 May 2016 05:45:56 -0700
Received: by  (sSMTP sendmail emulation); Thu, 26 May 2016 13:45:56 +0025
Date: Thu, 26 May 2016 13:45:55 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: Stephen Hurd <stephen.hurd@broadcom.com>
Cc: dev@dpdk.org
Message-ID: <20160526124555.GF7708@bricha3-MOBL3>
References: <CAJ9nmBYsstDhTCB4H1V5zGFD7ffTeXd=L+v+pdCjqB5KJ6AEvQ@mail.gmail.com>
 <1463179589-82681-1-git-send-email-stephen.hurd@broadcom.com>
 <1463179589-82681-24-git-send-email-stephen.hurd@broadcom.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1463179589-82681-24-git-send-email-stephen.hurd@broadcom.com>
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] [PATCH v2 24/40] bnxt: add HWRM ring alloc/free
 functions
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 26 May 2016 12:46:00 -0000

On Fri, May 13, 2016 at 03:46:13PM -0700, Stephen Hurd wrote:
> Add HWRM calls to allocate and free TX/RX/CMPL rings along with
> the associated structs and definitions.
> 
What are these RX/TX/CMPL rings used for? I assume they are different from the
RX/TX rings used to send/receive packets, or am I missing something?

Also, I see some compilation errors after applying this patch in the series.
gcc gives errors about "struct bnxt_ring_struct declared inside parameter list".

/Bruce

PS: having "struct" at the end of the name of "struct bnxt_ring_struct" seems
superflous. Since we don't use typedefs in DPDK, the keyword struct will always
appear before the definition, so it shouldn't be needed in the name too.