From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id EFB602C47 for ; Thu, 26 May 2016 15:25:27 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP; 26 May 2016 06:25:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,367,1459839600"; d="scan'208";a="975000446" Received: from bricha3-mobl3.ger.corp.intel.com ([10.252.31.37]) by fmsmga001.fm.intel.com with SMTP; 26 May 2016 06:25:25 -0700 Received: by (sSMTP sendmail emulation); Thu, 26 May 2016 14:25:24 +0025 Date: Thu, 26 May 2016 14:25:24 +0100 From: Bruce Richardson To: Stephen Hurd Cc: dev@dpdk.org Message-ID: <20160526132524.GJ7708@bricha3-MOBL3> References: <1463179589-82681-1-git-send-email-stephen.hurd@broadcom.com> <1463179589-82681-29-git-send-email-stephen.hurd@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1463179589-82681-29-git-send-email-stephen.hurd@broadcom.com> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v2 29/40] bnxt: work around HWRM error when creating rings X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 May 2016 13:25:28 -0000 On Fri, May 13, 2016 at 03:46:18PM -0700, Stephen Hurd wrote: > Some HWRM versions will stop responding if we request poll mode interrupt. > As a workaround, request an MSI interrupt even though we never enable it. > > Signed-off-by: Stephen Hurd > Reviewed-by: Ajit Kumar Khaparde > --- > drivers/net/bnxt/bnxt_hwrm.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c > index b5bc473..897e766 100644 > --- a/drivers/net/bnxt/bnxt_hwrm.c > +++ b/drivers/net/bnxt/bnxt_hwrm.c > @@ -581,7 +581,11 @@ int bnxt_hwrm_ring_alloc(struct bnxt *bp, > break; > case HWRM_RING_ALLOC_INPUT_RING_TYPE_CMPL: > req.ring_type = ring_type; > - req.int_mode = HWRM_RING_ALLOC_INPUT_INT_MODE_POLL; > + /* > + * TODO: Some HWRM versions crash with Is this really a TODO? If it's a workaround for an issue, surely it needs to stay in the code with the appropriate comment [which you have already added]. /Bruce