From: Bruce Richardson <bruce.richardson@intel.com>
To: Stephen Hurd <stephen.hurd@broadcom.com>
Cc: dev@dpdk.org, sys_stv@intel.com
Subject: Re: [dpdk-dev] [PATCH v3 31/40] bnxt: add start/stop/link update operations
Date: Thu, 26 May 2016 14:46:11 +0100 [thread overview]
Message-ID: <20160526134611.GL7708@bricha3-MOBL3> (raw)
In-Reply-To: <1463603381-89710-1-git-send-email-stephen.hurd@broadcom.com>
On Wed, May 18, 2016 at 01:29:41PM -0700, Stephen Hurd wrote:
> BNXT driver will now minimally pass traffic with testpmd.
>
> Signed-off-by: Stephen Hurd <stephen.hurd@broadcom.com>
> Reviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>
> ---
> drivers/net/bnxt/bnxt_ethdev.c | 267 +++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 267 insertions(+)
>
<snip>
> + memset(&new, 0, sizeof(new));
> + do {
> + /* Retrieve link info from hardware */
> + rc = bnxt_get_hwrm_link_config(bp, &new);
> + if (rc) {
> + new.link_speed = ETH_LINK_SPEED_100M;
> + new.link_duplex = ETH_LINK_FULL_DUPLEX;
> + RTE_LOG(ERR, PMD,
> + "Failed to retrieve link rc = 0x%d!", rc);
Checkpatch correctly flags this as an error. If you put 0x in front of a number
the output format needs to be %x rather than %d.
/Bruce
prev parent reply other threads:[~2016-05-26 13:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <9c8bee$sshbeq@fmsmga001.fm.intel.com>
2016-05-18 20:29 ` Stephen Hurd
2016-05-26 13:46 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160526134611.GL7708@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=stephen.hurd@broadcom.com \
--cc=sys_stv@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).