From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id C91834B79
 for <dev@dpdk.org>; Thu, 26 May 2016 15:46:43 +0200 (CEST)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga102.fm.intel.com with ESMTP; 26 May 2016 06:46:43 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,367,1459839600"; d="scan'208";a="989248360"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.252.31.37])
 by fmsmga002.fm.intel.com with SMTP; 26 May 2016 06:46:13 -0700
Received: by  (sSMTP sendmail emulation); Thu, 26 May 2016 14:46:12 +0025
Date: Thu, 26 May 2016 14:46:11 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: Stephen Hurd <stephen.hurd@broadcom.com>
Cc: dev@dpdk.org, sys_stv@intel.com
Message-ID: <20160526134611.GL7708@bricha3-MOBL3>
References: <9c8bee$sshbeq@fmsmga001.fm.intel.com>
 <1463603381-89710-1-git-send-email-stephen.hurd@broadcom.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1463603381-89710-1-git-send-email-stephen.hurd@broadcom.com>
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] [PATCH v3 31/40] bnxt: add start/stop/link update
	operations
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 26 May 2016 13:46:44 -0000

On Wed, May 18, 2016 at 01:29:41PM -0700, Stephen Hurd wrote:
> BNXT driver will now minimally pass traffic with testpmd.
> 
> Signed-off-by: Stephen Hurd <stephen.hurd@broadcom.com>
> Reviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>
> ---
>  drivers/net/bnxt/bnxt_ethdev.c | 267 +++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 267 insertions(+)
>
<snip>
> +	memset(&new, 0, sizeof(new));
> +	do {
> +		/* Retrieve link info from hardware */
> +		rc = bnxt_get_hwrm_link_config(bp, &new);
> +		if (rc) {
> +			new.link_speed = ETH_LINK_SPEED_100M;
> +			new.link_duplex = ETH_LINK_FULL_DUPLEX;
> +			RTE_LOG(ERR, PMD,
> +				"Failed to retrieve link rc = 0x%d!", rc);

Checkpatch correctly flags this as an error. If you put 0x in front of a number
the output format needs to be %x rather than %d.

/Bruce