From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 9AC1238EB
 for <dev@dpdk.org>; Thu, 26 May 2016 17:20:46 +0200 (CEST)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by fmsmga104.fm.intel.com with ESMTP; 26 May 2016 08:20:46 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,367,1459839600"; d="scan'208";a="709317598"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.252.31.37])
 by FMSMGA003.fm.intel.com with SMTP; 26 May 2016 08:20:44 -0700
Received: by  (sSMTP sendmail emulation); Thu, 26 May 2016 16:20:43 +0025
Date: Thu, 26 May 2016 16:20:43 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: Stephen Hurd <stephen.hurd@broadcom.com>
Cc: dev@dpdk.org
Message-ID: <20160526152042.GN7708@bricha3-MOBL3>
References: <CAJ9nmBYsstDhTCB4H1V5zGFD7ffTeXd=L+v+pdCjqB5KJ6AEvQ@mail.gmail.com>
 <1463179589-82681-1-git-send-email-stephen.hurd@broadcom.com>
 <1463179589-82681-40-git-send-email-stephen.hurd@broadcom.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1463179589-82681-40-git-send-email-stephen.hurd@broadcom.com>
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Subject: Re: [dpdk-dev] [PATCH v2 40/40] bnxt: cleanup null pointer checks
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 26 May 2016 15:20:47 -0000

On Fri, May 13, 2016 at 03:46:29PM -0700, Stephen Hurd wrote:
> Prefer !ptr to ptr == NULL
> 
> Signed-off-by: Stephen Hurd <stephen.hurd@broadcom.com>
> Reviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>

Nak to this particular patch, as it contradicts DPDK coding guidelines which is
to make NULL checks explicit. Ref [1]

/Bruce

[1] http://dpdk.org/doc/guides/contributing/coding_style.html#c-statement-style-and-conventions