DPDK patches and discussions
 help / color / mirror / Atom feed
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: Huawei Xie <huawei.xie@intel.com>, dev@dpdk.org, vincent.mc.li@gmail.com
Subject: Re: [dpdk-dev] [PATCH] virtio: check if devargs is NULL before checking its value
Date: Fri, 27 May 2016 10:09:43 +0800	[thread overview]
Message-ID: <20160527020943.GZ5641@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <1740935.53DGeJ2mHm@xps13>

On Wed, May 25, 2016 at 12:47:30PM +0200, Thomas Monjalon wrote:
> > -		    dev->devargs->type != RTE_DEVTYPE_WHITELISTED_PCI) {
> > +		    (!dev->devargs ||
> > +		     dev->devargs->type != RTE_DEVTYPE_WHITELISTED_PCI)) {
> 
> Should the title be something like "fix crash ..."?
> 
> I would also add
> Reported-by: Vincent Li <vincent.mc.li@gmail.com>

Huawei, the two are good comments (Thomas, thanks for the review, BTW :).

So, mind to send v2? BTW, I think this patch deserves some explanation,
say, why dev->devargs could be NULL.



	--yliu

  reply	other threads:[~2016-05-27  2:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-24 14:35 Huawei Xie
2016-05-25 10:47 ` Thomas Monjalon
2016-05-27  2:09   ` Yuanhan Liu [this message]
2016-06-01  5:50     ` Xie, Huawei
2016-06-13 14:53 ` [dpdk-dev] [PATCH v2] virtio: fix crash loading virtio driver when devargs isn't specified Huawei Xie
2016-06-14 13:19   ` Yuanhan Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160527020943.GZ5641@yliu-dev.sh.intel.com \
    --to=yuanhan.liu@linux.intel.com \
    --cc=dev@dpdk.org \
    --cc=huawei.xie@intel.com \
    --cc=thomas.monjalon@6wind.com \
    --cc=vincent.mc.li@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).