From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 4B7722C33 for ; Wed, 1 Jun 2016 09:12:56 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP; 01 Jun 2016 00:12:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,400,1459839600"; d="scan'208";a="978478554" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by fmsmga001.fm.intel.com with ESMTP; 01 Jun 2016 00:12:55 -0700 Date: Wed, 1 Jun 2016 15:15:46 +0800 From: Yuanhan Liu To: Huawei Xie Cc: dev@dpdk.org Message-ID: <20160601071546.GC10038@yliu-dev.sh.intel.com> References: <1462323027-91942-1-git-send-email-huawei.xie@intel.com> <1464599180-76004-1-git-send-email-huawei.xie@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1464599180-76004-1-git-send-email-huawei.xie@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v3] virtio: split virtio rx/tx queue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Jun 2016 07:12:56 -0000 On Mon, May 30, 2016 at 05:06:20PM +0800, Huawei Xie wrote: > We keep a common vq structure, containing only vq related fields, > and then split others into RX, TX and control queue respectively. > > Signed-off-by: Huawei Xie > --- > v2: > - don't split virtio_dev_rx/tx_queue_setup > v3: > - fix some 80 char warnings > - fix other newer version checkpatch warnings > - remove '\n' in PMD_RX_LOG Weird, I still saw them. Besides that, I found a crash issue with this patch applied. You could easily reproduce it by: testpmd> start tx_first testpmd> quit [82774.055297] testpmd[9661]: segfault at 94 ip 00000000004f7ef0 sp 00007ffcb1fa 66c0 error 4 in testpmd[400000+25b000] ./t.pmd: line 11: 9661 Segmentation fault (core dumped) $RTE_SDK/$RTE _TARGET/app/testpmd -c 0x1f -n 4 -- --nb-cores=4 -i --disable-hw-vlan --txqflags 0xf00 --rxq=$nr_queues --txq=$nr_queues --rxd=256 --txd=256 --yliu